Bug 62755

Summary:	konqueror tab navigation is reversed in right-to-left locales
Product:	[Applications] konqueror	Reporter:	Oded Arbel <oded>
Component:	tabbing	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Mandrake RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	snapshot of konqueror's "windows" menu Patch to fix the last remaining issue in this bug

Description Oded Arbel 2003-08-16 13:55:33 UTC

Version:            (using KDE KDE 3.1.3)
Installed from:    Mandrake RPMs
Compiler:          gcc 3.3 
OS:          Linux

In locals which use right to left (RTL) ordering (for example: hebrew), KDE's widgets are reversed (menus are displayed from right to left, navigation bar is displayed on the right, etc. konqueror tabs are also displayed from right to left, but trying to navigate through them using the CTRL-LEFT/CTRL-RIGHT shortcut keys produceses results the reverse of what is expected: pressing CTRL-LEFT will move a tab to the right (to the previos tab).

While in RTL locales, tab navigation should also reverse to reflect the fact that the previous tabs are on the right now and the next tab is on the left.

Comment 1 Wilco Greven 2003-10-11 13:50:53 UTC

Has been fixed in KDE CVS already.

Comment 2 Oded Arbel 2003-10-13 20:33:39 UTC

In today's CVS it's still a problem. I can live with the default keyboard shortcuts (ctrl-[ / 
ctrl-]), but they're still reversed in RTL locales. 
 
I think its an issue with 'next/previous' vs. 'left/right' - the keyboard shortcut is defined as 
"move to next tab", but it looks like "go right", so the user is surprised when it goes left 
(next on RTL locales). 
 
BTW - the defaults for "next tab" are CTRL-< and CTRL-]  which look to be wrong to me - 
as one is pointing left and one is pointing right. no matter what locale your in, one of them 
will be wrong. 
 
Another thing, it may be just a bug somewhere on my system, but on today's CVS both 
CTRL-> and CTRL-< do "previous tab" while CTRL-] and CTRL-[ work as expected ( = 
ignore their obivous mnemonics and consentrate on the "next/previous" meaning).

Comment 3 Stephan Binner 2003-12-20 23:27:09 UTC

*** Bug has been marked as fixed ***.

Comment 4 Oded Arbel 2003-12-21 17:27:56 UTC

Tab navigation works ok now - thanks, but tab re-ordering (windows->move tab left/right) is still reversed.

I'm re-opening this bug because I think its the same issue (sorry for not mentioning this specificly earlier). if you think I'm wrong and a new bug should be opened, then close this bug.

Comment 5 Oded Arbel 2003-12-21 17:29:27 UTC

Created attachment 3810 [details]
snapshot of konqueror's "windows" menu

Checkout what the cursor is highlighting. I think its funny, but I bet new KDE
users will be less amused :-)

Comment 6 Oded Arbel 2004-01-26 12:48:10 UTC

Created attachment 4353 [details]
Patch to fix the last remaining issue in this bug

Here's a patch against current CVS to fix the problem in comments 4 and 5. this
works for me and as far as I can tell doesn't break anything.

The issue is simply that in an RTL locale that meaning of "left" and "right" do
not change - left is still left and right is still right - but the meaning of
"first" and "last" are reversed!
The previous behavior of KonqMainWindow::initActions() would have you believe
that in an RTL locale left is right and right is left ;-)

Comment 7 Stephan Binner 2004-01-27 10:31:07 UTC

Applied patch for KDE 3.2.1.