Bug 61758

Summary: execute command dialog is redundant
Product: [Applications] kdevelop Reporter: tnagy <tnagy256>
Component: generalAssignee: KDevelop Developers <kdevelop-devel>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: git master   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Other   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description tnagy 2003-07-28 14:36:10 UTC
Version:           gideon cvs snapshot 20030727 (using KDE KDE 3.1.1a)
Installed from:    Unspecified Linux
Compiler:          gcc 3.2 
OS:          I Don't Know

The "Tools->execute_command" option is redundant : 
* The user can use the embedded konsole instead.
* The user can use the Alt+F2 shortcut
* There is no code completion in this dialog
* It makes one more unnecessary entry in the "Tools" menu

I suggest to remove this unnecessary feature, or to launch the general kde application launcher instead (Alt+F2).
Comment 1 Alexander Dymo 2003-07-28 23:55:51 UTC
"Execute command" is not for usual command execution. It executes command 
and directs it's output to an active editor window. So this isn't unnecessary 
feature. 
By the way, you don't have to vote 20 times for your bugs. 
Comment 2 tnagy 2003-07-29 00:16:23 UTC
I'm sorry 19 times but I must hold my position !

I find this dialog highly counter-intuitive, and I can't believe that I am the
only one. The window caption ("gideon" ??) does not reflect the fact that the
dialog is meant to insert the result of the command into the editor ! This is an
obfuscated feature ! ;-)

This feature can indeed be useful, but with at least some more "clues" for the
users.

What's more, there isn't anything to prevent from inserting a lot of garbage
into the editor (what if I type ls /usr/bin or cat *.cpp ?) 

An embedded konsole, with a window to see the result of the command would be in
fact more appropriate.

Comment 3 Alexander Dymo 2003-07-30 00:05:46 UTC
Subject: kdevelop/parts/filter

CVS commit by dymo: 

Added tooltips for actions and captions for dialogs.
CCMAIL: 61758-done@bugs.kde.org


  M +13 -6     filterpart.cpp   1.10


--- kdevelop/parts/filter/filterpart.cpp  #1.9:1.10
@@ -39,8 +39,10 @@ FilterPart::FilterPart(QObject *parent, 
                           this, SLOT(slotShellInsert()),
                           actionCollection(), "tools_insertshell" );
+    action->setToolTip(i18n("Executes a shell command and outputs it's result into the current document"));
 
     action = new KAction( i18n("Filter Selection Through Command..."), 0,
                           this, SLOT(slotShellFilter()),
                           actionCollection(), "tools_filtershell" );
+    action->setToolTip(i18n("Filters selection trough a shell command and outputs it's result into the current document"));
 
     m_insertDialog = 0;
@@ -86,6 +88,8 @@ void FilterPart::slotShellInsert()
 
     if (!m_insertDialog)
+    {
         m_insertDialog = new ShellInsertDialog();
-
+        m_insertDialog->setCaption(i18n("Execute Command"));
+    }
     if (m_insertDialog->exec()) {
         uint line, col;
@@ -130,5 +134,8 @@ void FilterPart::slotShellFilter()
 
     if (!m_filterDialog)
+    {
         m_filterDialog = new ShellFilterDialog();
+        m_filterDialog->setCaption(i18n("Filter Selection Through Command"));
+    }
 
     kdDebug(9029) << "Old text: " << selectioniface->selection()<< endl;


Comment 4 tnagy 2003-07-30 00:16:54 UTC
This is better ;-)