Bug 61223

Summary: Some online users are shown as offline
Product: [Unmaintained] kopete Reporter: Ladislav Strojil <ladislav.strojil>
Component: ICQ and AIM PluginsAssignee: Kopete Developers <kopete-bugs-null>
Status: CLOSED FIXED    
Severity: major CC: carsten.schlipf, daniel, davidpeter, heinrich.wendel, ifinci, ismail, kdebugs, npaulin, patrick, ryan, stormlabs, sts, techniq35
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Ladislav Strojil 2003-07-14 16:06:35 UTC
Version:           CVS (14.7.2003) (using KDE KDE 3.1.2)
Installed from:    Compiled From Sources

ICQ plugin shows some online users as offline.
At first I thought this has something to do with the client the remote side uses, but now I am begining to suspect that it is somehow connected to my serverside contact list.
Seems to me that only contacts that are on my serverside CL show their online status correctly.
However, I cannot really test this. 
But I have tested Kopete vs Licq, Kopete vs Kopete, Kopete vs ICQ 2002 - with all of these I was able to see offline user instead of online.
How is serverside contact synchronized? Is it at all?
Comment 1 Dirk Mueller 2003-07-14 16:22:39 UTC
*** Bug 61224 has been marked as a duplicate of this bug. ***
Comment 2 Dirk Mueller 2003-07-14 16:24:57 UTC
*** Bug 61220 has been marked as a duplicate of this bug. ***
Comment 3 Ladislav Strojil 2003-07-14 16:28:08 UTC
Oh, sorry for the fuzz, it seems there's something wrong with the component list for kopete. 
Searching for ICQ return "AIM Plugins -". Selecting this causes the bugs to be assigned to no 
product and not component. Thanks Dirk for putting those bugs right. 
Comment 4 Ladislav Strojil 2003-07-14 18:37:19 UTC
OK, so I've tested some more. I used ICQlite under Windows to add some of the 
contacts to my serverside contact list and they started showing correctly. 
So the bug is:  
1) adding contact locally does not add it to serverside contact list 
OR 
2) contacts not on serverside CL are shown with incorrect online status.  
 
I don't know about inner workings of Oscar, so I think it's both 1 and 2. But I can be 
mistaken, of course. 
 
Comment 5 Will Stephenson 2003-07-14 18:42:23 UTC
Confirmed, I just added Matt Rogers and he appears offline to me.  However, he 
sees my status correctly.  Could this be something to do with 
authorisation-required ICQ accounts? 
 
Comment 6 Ladislav Strojil 2003-07-14 18:56:58 UTC
I added one of those UIN to my serverside CL (using ICQLite) and when he sent me 
the authorization (I was back in kopete by then), he appeared online.  
The problem is that I cannot really be sure that he would not be online without 
sending me the authorization, because he sent it few seconds after he changed his 
status to online. So I cannot really tell if it was adding to serverside CL or recieving 
authorization that did the trick. My guess is that it was authorization. 
Comment 7 Stefan Gehn 2003-07-14 19:15:05 UTC
it's probably all the stupid AUTh stuff. Also grep for "WAITAUTH" in sources, that bit 
in the contactlist means that you are still awaiting auth from that user IIRC. 
If more detail about the auth system is required I can probably answer most of it (as 
usual, I know how it works, I just don't know how to write proper code for it). 
Comment 8 Js Lebacq 2003-07-16 14:14:33 UTC
a friend has sent an autorization to me, but he's always showed off-line 
 
Comment 9 Js Lebacq 2003-07-16 20:11:42 UTC
ok, I try the "ICQLite method", and it works.  Adding  UIN to the serverside CL is not 
enough, and having autorization is not enough, but "adding  UIN to the serverside CL 
and then asking autorization " works. 
Comment 10 ifinci 2003-08-07 11:30:16 UTC
One more thing that I can not find, is how I add a user to the serverside CL, or how 
to set if a user need my authorization or not. 
Comment 11 Olivier Goffart 2003-08-09 12:03:32 UTC
*** Bug 62379 has been marked as a duplicate of this bug. ***
Comment 12 Ricardo Ferreira 2003-08-11 21:00:27 UTC
I also have this bug. All my contacts are on my server side CL. 
I rmed contactlist.xml and then connected & all my contacts reappeared, so i 
know they're on the server side CL. 
 
However only 2 of my contacts report their online status correctly. All other stay 
offline even if they are online. SIM works as does all other clients i tested. 
 
This is the only bug that really annoys me in kopete. 
Comment 13 Stefan Gehn 2003-08-11 23:04:20 UTC
I'm currently trying my best at the auth part, please be patient, I'm not yet sure 
how the authorization process works (looks like I'm missing flags for my account 
using that AUTH feature). 
Comment 14 Paul Sandulescu 2003-08-13 17:44:57 UTC
I also have this problem with the MSN and Yahoo plugins... They both show 
users offline when they aren't. I'm using 0.7v self-compiled on Debian 
unstable. In my opinion, kopete should provide better control to the user for 
serverside CL's and make clear distinction between its own CL and serverside, 
whatever the protocol. 
Comment 15 ifinci 2003-08-14 08:04:24 UTC
It seems that in version 0.7.1 the online status of users works much better (at
least in ICQ where I saw the problem before, and have a way to check).
Comment 16 Matija Å uklje 2003-08-17 13:13:40 UTC
kopete-0.7.1 on gentoo (installed/emerged from source) 
...the problem not fixed :( 
Comment 17 Heinrich Wendel 2003-08-26 18:21:41 UTC
i think this should be fixed for 0.7.2 
Comment 18 Stefan Gehn 2003-08-26 20:06:21 UTC
Yeah, I think we should fix all bugs and support all possible features of all IM-system 
in 0.7.2, that would be cool, eh? ;) LOL 
Comment 19 Ricardo Ferreira 2003-08-26 20:17:18 UTC
Yeah, it would be cool :) 
But seriously, this is the bug thats keeping me from using kopete instead of 
sim-icq. 
Comment 20 Stefan Gehn 2003-08-26 20:33:50 UTC
CVS should already improve the situation as you can request authorization from 
somebody on your serverside-contactlist. I successfully received an "auth accept" 
from somebody else and since then he's online for me. 
One big bug is still unsolved though: I goddamn cannot add contacts to serverside 
contactlist anymore and don't know why (it used to work before I think) :(( 
Comment 21 Heinrich Wendel 2003-08-26 22:12:17 UTC
> Yeah, I think we should fix all bugs and support all possible features of all IM-system in 0.7.2, 
that would be cool, eh? ;) LOL  
 
very funny... 
 
as Ricardo said, this also stops me from using kopete 0.7, it is working fine in 0.6, so why not in 
0.7 ;) 
Comment 22 Axel 2003-08-30 18:58:41 UTC
I'm using version 0.7.1 of Kopete. All online contacts are shown under "Connected contacts" 
(Checked with icq2go). But only one is coloured. The other contacts are dimmed out. 
Comment 23 Martin van Es 2003-09-10 10:50:25 UTC
Just DL'ed and compiled 0.7.2: no improvement on the ICQ problem. Kopete doesn't
even seem able to connect with the ICQ server. I have no server-side ICQ
contactlist (AFAIK).
MSN seems to work and I get no 'upgrade now' message from their staff anymore. 
Comment 24 Martijn Klingens 2003-09-10 11:00:22 UTC
Subject: Re: [Kopete-devel]   Some online users are shown as offline

On Wednesday 10 September 2003 10:50, Martin van Es wrote:
> Just DL'ed and compiled 0.7.2: no improvement on the ICQ problem.
> Kopete doesn't even seem able to connect with the ICQ server. I have
> no server-side ICQ contactlist (AFAIK).

Assuming that you do actually get a connection this was to be expected. 
According to Stefan there are multiple causes for this that cannot be solved 
easily.

One being the lack of a server side list, but another one for example has to 
do with requiring authentication on either end.

I'm sure Stefan can tell you all the boring details. Perhaps he also has some 
ideas to get it working, or to help help fix some more issues. At least let's 
hope so...

Comment 25 Martin van Es 2003-09-10 12:42:46 UTC
With oktober 15 creeping neerer every day and Kopete/ICQ not completely a
working system (at least with Oscar) isn't it an idea to re-enable ICQ (old
style) plugin for 0.7.3?
0.6.2 Works like a charm, except for the old MSN protocol.

Martin
Comment 26 Jorma Tuomainen 2003-09-10 14:08:16 UTC
ICQ isn't working on 0.7.2 with KDE 3.1.3. Not getting that .net messenger 
staff message anymore so thats step forward. 
Comment 27 Martijn Klingens 2003-09-10 14:13:03 UTC
Subject: Re: [Kopete-devel]   Some online users are shown as offline

On Wednesday 10 September 2003 12:42, Martin van Es wrote:
> With oktober 15 creeping neerer every day and Kopete/ICQ not completely a
> working system (at least with Oscar) isn't it an idea to re-enable ICQ (old
> style) plugin for 0.7.3?
> 0.6.2 Works like a charm, except for the old MSN protocol.

Patches welcome, I can assure you that the API changes during Kopete 0.7.x 
(multiple accounts per protocol) will keep you busy for quite some days to do 
this :)

(Not to mention I don't like the idea either, better fix OSCAR, even if that 
costs more time initially as it's the better and more viable protocol on the 
longer term.)

Comment 28 Stefan Gehn 2003-09-10 15:23:37 UTC
I'll close this soon if users go on mixing up protocols, MSN has nothing to do with 
ICQ and I'm not going to explain the problems we have in OSCAR a 425636th time. 
Comment 29 Romuald Texier 2003-09-21 17:20:48 UTC
Hint: Oscar works really well in Gaim. Since it is open source, you should find
ideas in its code.
Comment 30 Stefan Gehn 2003-09-21 17:36:54 UTC
Hint: stop giving useless hints or I'll hit you with a hint 
Comment 31 Mike W 2003-09-22 17:08:03 UTC
I am also getting this behaviour with ICQ/OSCAR in CVS (compiled today, but i 
recompile everyday:) (using kde 3.1.4)..  
 
it was working for a long time, then about 2-3 weeks ago it stopped again.. I 
made sure to try to readd everyone to the server side CL (had already done it, 
but manually went into contactlist.xml and reset the status so i could do it 
again) but nothing changed, and some still dont show up..  
 
theyre usually linux users (kopete/GAYM) or trillian users (ie not official icq 
clients) or ICQLite users (dont know if thats 'official') 
Comment 32 Romuald Texier 2003-09-22 17:15:51 UTC
Looks like they never appear on the Server CL. ICQ requires the buddy to authorize you 
and it looks like Kopete does not send an authorisation request. 
So I use another client (like GAIM) to add new buddies, and once the buddy has 
accepted, everything works fine in Kopete again. 
Comment 33 Stefan Gehn 2003-09-22 17:23:56 UTC
If this bugreport goes on like that I'll close it as invalid. There can be 10052536 
people posting "I have the same problem", that still does not improve the situation. 
Comment 34 Mike W 2003-09-22 17:40:09 UTC
well then how about suggesting something youd like us to do to help debug?.. 
you want some console output?... copy of contact list?... just ask and ye shall 
receive 
Comment 35 Stefan Gehn 2003-10-19 18:32:23 UTC
*** Bug 64768 has been marked as a duplicate of this bug. ***
Comment 36 Thomas Kjosmoen 2003-10-22 02:14:00 UTC
Is there any progress with this problem? (I'd love to be able to stop using Sim ;-)
I'm using the latest CVS version (>= 20031007), and contacts that have not been authorized always show as offline and the "Request authorization" option (seem to be the exact same as "Send authorization") on the right click menu is not available when contacts are "offline". Also, neither sending nor receiving authorization works.
Comment 37 ieure 2003-11-10 01:53:38 UTC
FWIW, I ran into this with 0.7.3 yesterday. An AIM user had messaged me, and I could see their messages, but they were showing up as offline.

I removed them from my contact list, explicitly added them (they weren't in my list when I got the first message), and I was able to see their status.

Anyone else see this behavior?
Comment 38 Stefan Gehn 2003-11-11 21:07:57 UTC
*** Bug 66259 has been marked as a duplicate of this bug. ***
Comment 39 Casey Allen Shobe 2003-12-07 02:24:26 UTC
*** Bug 69734 has been marked as a duplicate of this bug. ***
Comment 40 Andreas Bauer 2003-12-10 21:04:44 UTC
Hello together

Just wanted to know if there is still someone working on this problem. Really a very anoying problem. 

Let me know if I can help out somehow. (everything exept coding)

take care
&i
Comment 41 Stefan Gehn 2003-12-10 21:32:15 UTC
And even if you knew it wouldn't help.
Comment 42 Brandon 2003-12-10 21:45:05 UTC
This has my vote... today I could not reply to someone that was instant messaging me!  It said she was not online! lol!  It was AIM by the way.  I am using 0.7.4 (unofficial mandrake rpm)

Brandon
Comment 43 Stefan Gehn 2003-12-10 22:00:54 UTC
No more votes and/or non-informative comments please.

The bug IS known and it's the next thing that will get fixed after KDE 3.2 but without developers having time to fix this you won't see it fixed soon.
It's unimportant if we have 14536464 users voting for this bug as long as we lack good coders (and we do, I can tell you).
Just wait or raise your hands in case you know how to do nice OO designs, I apparently don't (otherwise I would have started the rewrite already)
Comment 44 Marcelo Penna Guerra 2003-12-10 22:04:56 UTC
For what I read on the bug report and mailing-lists, the problem is not that OSCAR doesn't have a mantainer (BTW, keep up the good work, Mr. Gehn, and corret me if I'm wrong) or lack of documentation. The problem is deciding how to fix the server side list support on the current code. Seems like it'll take some design changes that will probably break other things, so it's not something to be done just before the KDE 3.2 release, as the goal is to ship it with the least bugs as possible. This will probably be worked out as soon as the 3.2 release is tagged.

This is annoying, but you can work around it using the ICQ web client, for example. So, let's forget this for now, vote for the bug if it annoys you, but don't post any more comments. There's nothing you can post here that Kopete developers don't know, they are very aware of this bug, what is causing it and how much it annoys people, and they will fix it as soon as possible.
Comment 45 Casey Allen Shobe 2003-12-11 04:06:54 UTC
> It's unimportant if we have 14536464 users voting for this bug as long as we
> lack good coders (and we do, I can tell you).

This is not true.  More votes attract more attention (i.e. this is currently #5 on the KDE most-hated list.  Such placement attracts more developers looking for things to fix which will make the most influence to KDE users.  So please vote on this, but restrict comments to if you have something of good contribution value to add.
Comment 46 Casey Allen Shobe 2003-12-12 04:37:35 UTC
*** Bug 70171 has been marked as a duplicate of this bug. ***
Comment 47 George Staikos 2003-12-12 04:45:10 UTC
It has 557 votes, 46 comments, at least 7 reported dupes, it seriously impedes functionality, and it's set to severity "normal"?  I'll be conservative and say "Major".  I'm tempted to say it's not worth shipping this plugin in 3.2 if we're going to get N times this many reports when people start using the stable release.  Release dude?
Comment 48 Stephan Kulow 2003-12-12 09:51:53 UTC
The question comes down to: can it be worked around on the user's side or is he  lost with it. To me this is really a normal bug - it might be very visible to ICQ users (I can't even judge that) but still people might be happy to have ICQ at all. If all they have to do is to restart ICQ or relogin or whatever, that's fine.
Comment 49 Christian Muehlhaeuser 2003-12-12 10:01:25 UTC
Well, then it's not fine. Most of my ICQ users (except two people) are _always_ offline. No matter what you do. No matter if you remove them. No matter if you re-add them. Using some other client they're online. Interesting: Old Kopete versions still work like a charme.

Comment 50 George Staikos 2003-12-12 10:23:14 UTC
Subject: Re:  Some online users are shown as offline

On Friday 12 December 2003 04:01, you wrote:
> Well, then it's not fine. Most of my ICQ users (except two people) are
> _always_ offline. No matter what you do. No matter if you remove them. No
> matter if you re-add them. Using some other client they're online.
> Interesting: Old Kopete versions still work like a charme.

   I agree.  I see this too, which makes ICQ virtually impossible to use and I 
think will cause quite a headache when it is officially released as 3.2.  I 
think it should either be escalated or disabled for 3.2.0.

Comment 51 Conrad Hoffmann 2003-12-12 10:38:48 UTC
This issue has been discussed more than just several times, and no, going back to the behaviour of an old kopete-version is neither possible nor desireable, and if you think it's unusable, don't use it. I for my part am VERY content to have a working ICQ in a multi-protocol IM-program. If you want to keep on using ICQ, there's a pretty simple work-around to all this (at least that did the trick for me):
when you have a new contact, close kopete (or go offline on ICQ) and go to go.icq.com, add the new contact to your list, or if already present, request authorization from him. you can then go back to kopete, and as soon as the user authorized you, he will appear online...
also i think it's a good idea to do group-management on icq2go, then close kopete, delete contactlist.xml and restart...
no app/plugin is perfect, but if you think it should be made unavailable because of that, kde would'nt have half the functionality....
Comment 52 George Staikos 2003-12-12 10:47:23 UTC
Subject: Re:  Some online users are shown as offline

  How is it that LICQ has no problems?

Comment 53 Christian Muehlhaeuser 2003-12-12 10:51:06 UTC
i'm not talking about making it unavailable - i'm talking about fixing it. other im clients do show the right status, so kopete should have the possibility, too. telling users to go to icq2go is def. not a kind of solution. as far as i was told, kopete's icq plugin got no (active) maintainer right now, is this still correct? if so, we should quickly find someone who's taking up the work, again. in my eyes it's not acceptable, that kde's standard messanger is not able to talk to icq properly.

btw: i was already told about the authorization / icq2go workaround by tigloo some time ago. didn't help anything.

2cents,
muesli
Comment 54 Martijn Klingens 2003-12-12 10:59:48 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

On Friday 12 December 2003 10:47, George Staikos wrote:
>   How is it that LICQ has no problems?

LICQ and almost all other clients but Gaim use the outdated native ICQ 
protocol, rather than the unified OSCAR protocol that's also used by AIM.

Also note Stefan's comments stating that it's the ICQ plugin's contact list 
handling that makes it break. There are still many leftovers from the *cough* 
Kit *cough* TOC code there, and the mixture between the two APIs makes the 
code hard to maintain and extremely error-prone.

Refactoring that out is the obvious solution, but it takes time, and none of 
us has that at the moment. The risk of regressions is also pretty steep, so 
this close before release I'm worried to do so anyway.

Comment 55 Heinrich Wendel 2003-12-12 11:04:11 UTC
So when are you going to begin with the work? This bug is open since *5* month.
Comment 56 George Staikos 2003-12-12 11:04:23 UTC
Subject: Re:  Some online users are shown as offline

On Friday 12 December 2003 04:59, you wrote:
> On Friday 12 December 2003 10:47, George Staikos wrote:
> >   How is it that LICQ has no problems?
>
> LICQ and almost all other clients but Gaim use the outdated native ICQ
> protocol, rather than the unified OSCAR protocol that's also used by AIM.

  What I am suggesting is that maybe it is prudent to use the old protocol 
until the new one is functional.  That way you don't lose functionality.

Comment 57 Martijn Klingens 2003-12-12 11:11:20 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

On Friday 12 December 2003 11:04, George Staikos wrote:
>   What I am suggesting is that maybe it is prudent to use the old protocol
> until the new one is functional.  That way you don't lose functionality.

I don't think you know how much effort that would be or you wouldn't be 
suggesting it :)

The old (Kopete 0.6.x) code can't be easily made fit for our current API, and 
writing a new implementation from scratch is no easy feat either.

I think the refactoring is not only a more forward-looking solution, but even 
a FASTER solution.

That said, I haven't worked on ICQ/AIM for ages now, I don't even use the 
protocols anymore, so Stefan might be the better person to talk to.

Comment 58 George Staikos 2003-12-12 11:14:57 UTC
Subject: Re:  Some online users are shown as offline

On Friday 12 December 2003 05:11, you wrote:
> On Friday 12 December 2003 11:04, George Staikos wrote:
> >   What I am suggesting is that maybe it is prudent to use the old
> > protocol until the new one is functional.  That way you don't lose
> > functionality.
>
> I don't think you know how much effort that would be or you wouldn't be
> suggesting it :)
>
> The old (Kopete 0.6.x) code can't be easily made fit for our current API,
> and writing a new implementation from scratch is no easy feat either.

   Yes, I don't know that code at all.  My other suggestions are to disable 
ICQ for 3.2.0, or to fix the problems, of course.  The number of bug reports 
for this will be quite impressive.  You must know this.  In addition, Kopete 
is very anticipated as a major part of 3.2.0.  If it comes out with major 
bugs such as this, it will most certainly get bad press.  Again, I think this 
is a show stopper in one sense or another.

Comment 59 Martijn Klingens 2003-12-12 11:26:48 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

On Friday 12 December 2003 11:14, George Staikos wrote:
> My other suggestions are to disable ICQ for 3.2.0,

If this were winpopup, SMS, or another hardly-used plugin I would have 
proposed this months ago.

Unfortunately ICQ is one of the most widely used plugins, and not shipping ICQ 
support would make for about as bad press as shipping broken ICQ support :(

There's still time, perhaps some of the issues can be resolved in time, but 
either way this is a lose-lose situation for Kopete :(

Comment 60 George Staikos 2003-12-12 11:30:20 UTC
Subject: Re:  Some online users are shown as offline

On Friday 12 December 2003 05:26, you wrote:
> > My other suggestions are to disable ICQ for 3.2.0,
>
> If this were winpopup, SMS, or another hardly-used plugin I would have
> proposed this months ago.
>
> Unfortunately ICQ is one of the most widely used plugins, and not shipping
> ICQ support would make for about as bad press as shipping broken ICQ
> support :(
>
> There's still time, perhaps some of the issues can be resolved in time, but
> either way this is a lose-lose situation for Kopete :(

   This is exactly the problem though.  It is so popular that this bug will be 
very widely visible.  It will result in a huge number of bug reports  (we 
already have hundreds of votes and dozens of comments!) and it will 
definitely result in bad press/reviews.  Shipping without ICQ and saying "due 
to unresolved technical issues, we will make the plugin available for 
separate download at a later date" makes much more sense.  That's the point 
of plugins instead of built-in protocols, right?

Comment 61 Ricardo Ferreira 2003-12-12 18:21:39 UTC
Just to add that sim (sim-ice.sourceforge.net) version 0.9.0 also uses OSCAR (it supports both ICQ & AIM) and doesnt have this problems. It runs under KDE.
Comment 62 Casey Allen Shobe 2003-12-12 22:46:27 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

Stephan Kulow (f
Comment 63 Casey Allen Shobe 2003-12-12 22:50:09 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

Conrad Hoffmann (f
Comment 64 Casey Allen Shobe 2003-12-12 22:54:36 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

George Staikos (f
Comment 65 Casey Allen Shobe 2003-12-12 23:06:24 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

George Staikos (f
Comment 66 Benoit Walter 2003-12-12 23:20:46 UTC
Subject: Re:  Some online users are shown as offline

Waow, what a huge bug, so much enthusiasm :-) What about making a big contest 
on dot.kde.org with the help of a big sponsor (solving a bug in 1 week)? Just 
kidding, kopete is great but for the moment, it should definitely be released 
separately, otherwise this release would give the feeling that kopete and kde 
are buggy. What? All of that as already been discussed in depth?? Ah.

Cheers,
Benoit.

Comment 67 George Staikos 2003-12-12 23:25:23 UTC
Subject: Re:  Some online users are shown as offline

On Friday 12 December 2003 17:20, Benoit Walter wrote:
> Waow, what a huge bug, so much enthusiasm :-) What about making a big
> contest on dot.kde.org with the help of a big sponsor (solving a bug in 1
> week)? Just kidding, kopete is great but for the moment, it should
> definitely be released separately, otherwise this release would give the
> feeling that kopete and kde are buggy. What? All of that as already been
> discussed in depth?? Ah.

  It's a plugin - kopete in general is quite solid.  The suitable solutions 
are either a) fix the problems  or b) release kopete without the plugin and 
ship the plugin later when it's ready

Not hard, and everyone wins.

Comment 68 Jason Keirstead 2003-12-12 23:31:50 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

>
>I think that releasing the plugin in it's current state would be catastrophic 
>(has anyone considered that even when this bug is fixed, it may be necessary 
>to go through a series of steps to actually get a user affected by the old 
>bug to show up right?  If you include this in the release, that may be 
>forcing all of the users to go through these nasty workarounds when 3.2.1 or 
>3.3 is released).
>
>
>  
>

Why hasn't anyone suggested the obvious solution?

This bug ONLY affects new contacts added through Kopete. It DOES NOT 
affect contacts added via
other clients.

If this bug is not fixed, you can simply remove the ability to add new 
ICQ contacts via Kopete.

Plugin exists without bug, still totally usable for people who have 
existing accounts. You add it to the
README / whatever that you need to add accounts with a different client.

ICQ plug in released, problem solved.

Comment 69 George Staikos 2003-12-12 23:38:54 UTC
Subject: Re:  Some online users are shown as offline

On Friday 12 December 2003 17:31, you wrote:
> Why hasn't anyone suggested the obvious solution?
>
> This bug ONLY affects new contacts added through Kopete. It DOES NOT
> affect contacts added via
> other clients.
>
> If this bug is not fixed, you can simply remove the ability to add new
> ICQ contacts via Kopete.
>
> Plugin exists without bug, still totally usable for people who have
> existing accounts. You add it to the
> README / whatever that you need to add accounts with a different client.
>
> ICQ plug in released, problem solved.

   Yes this is a viable solution.  It's still rather broken, but it solves 
most of the problems and is no longer classifiable as a show-stopper bug as 
far as I can tell.

Comment 70 Casey Allen Shobe 2003-12-13 00:32:25 UTC
Subject: Re:  Some online users are shown as offline

Benoit Walter (f
Comment 71 Casey Allen Shobe 2003-12-13 00:34:19 UTC
Subject: Re:  Some online users are shown as offline

f
Comment 72 Jason Keirstead 2003-12-13 05:17:41 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

If this bug is not fixed, you can simply remove the ability to add new

>>ICQ contacts via Kopete.
>>    
>>
>
>Adding contacts works fine.  The problem is when a contact not on your list 
>messages you.
>
>  
>
No it does not, and no it is not. The problem is entirely with adding 
new contacts in Kopete. This is why Stefan got so pissed off, everyone 
on this whole thread is not stating the problem correctly.

With any ICQ client at all, you can't see the status of someone who 
messages you and is not on your list. They need to be on your list, as 
in, you need to be authorized by them to see your status. But because 
new ICQ contacts in Kopete are NEVER added correctly, you won't ever see 
their status update.

Any contact added through Kopete will never have his online status 
updated properly, whether they messaged you or not

That is the only problem with the plug in, and the problem that Stefan 
has repeated over and over again will take a lot to fix because of the 
internals being so screwed up RE syncing with the server.

However, contacts added via another client are fine, because the sync TO 
Kopete works.
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1">
  <title></title>
</head>
<body>
If this bug is not fixed, you can simply remove the ability to add new<br>
<blockquote type="cite"
 cite="mid20031212233420.21273.qmail@ktown.kde.org">
  <blockquote type="cite">
    <pre wrap="">ICQ contacts via Kopete.
    </pre>
  </blockquote>
  <pre wrap=""><!---->
Adding contacts works fine.  The problem is when a contact not on your list 
messages you.

  </pre>
</blockquote>
No it does not, and no it is not. The problem is entirely with adding
new contacts in Kopete. This is why Stefan got so pissed off, everyone
on this whole thread is not stating the problem correctly.<br>
<br>
With any ICQ client at all, you can't see the status of someone who
messages you and is not on your list. They need to be on your list, as
in, you need to be authorized by them to see your status. But because
new ICQ contacts in Kopete are NEVER added correctly, you won't ever
see their status update.<br>
<br>
Any contact added through Kopete will never have his online status
updated properly, whether they messaged you or not<br>
<br>
That is the only problem with the plug in, and the problem that Stefan
has repeated over and over again will take a lot to fix because of the
internals being so screwed up RE syncing with the server.<br>
<br>
However, contacts added via another client are fine, because the sync
TO Kopete works.
</body>
</html>
Comment 73 Casey Allen Shobe 2003-12-13 08:29:14 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

Jason Keirstead (f
Comment 74 gerein 2003-12-13 12:17:04 UTC
> WRONG. When an AIM user OR ICQ user messages me who is not on my list, I 
> cannot see their online presence (and thus on AIM I have no way to message 
> them). However I can add new AIM and ICQ users *just fine* without any 
> problems unless the remote ICQ user requires authorization (a different bug).

Well, this bug is (originally at least) about ICQ and there receiving messages from contacs not on your list works just fine (just tried it). You don't get a contact icon, but as long as the chat window is open you can send messages without problems. Is that really different with AIM?

Otherwise Jason is right. If you add someone who requires authorization the request is not send and the contact is not added to the server side. And reading through the OSCAR-docs and the code it is not as trivial as it sounds (although I don't understand all of it). Stefan added a "Request Authorization" option, but it seems only to work if the contact is already in "waiting for auth"-state...?

So, please, shipping Kopete with ICQ is ridiculous. It works absolutely fine if you have an existing OSCAR-account. Disabling adding should be okay. Or maybe put newly added contacts in some kind of "unknown"-state (actually this could apply to all contacts which are on the local but not the server-contactlist) which is erased when they are online the first time, so that you can properly add them with another client and then use them in Kopete.
Comment 75 gerein 2003-12-13 16:06:36 UTC
Ok, so I looked through the code more closely and came up with the following patch. It's an ugly hack, but makes it possible to add ICQ contacts (don't know about aim) without the help of external clients:

--- protocols/oscar/oscarsocket/oscarsocket.cpp 12 Nov 2003 20:59:39 -0000      1.148
+++ protocols/oscar/oscarsocket/oscarsocket.cpp 13 Dec 2003 14:52:01 -0000
@@ -3249,14 +3249,17 @@
        outbuf.addWord(item->gid); // TAG
        outbuf.addWord(item->bid); // ID
        outbuf.addWord(item->type); // TYPE
-       outbuf.addWord(item->tlvlength); // LEN
+
+       outbuf.addWord(4);
+       outbuf.addTLV(0x0066, 0, 0L);
+/*     outbuf.addWord(item->tlvlength); // LEN

        if (item->tlvlength > 0)
        {
                kdDebug(14150) << k_funcinfo << "Adding TLVs with length=" <<
                        item->tlvlength << endl;
                outbuf.addString(item->tlvlist,item->tlvlength);
-       }
+       }*/

        sendBuf(outbuf,0x02);


The additional 0x0066-TLV at the end of the (0x13,0x08)-SNAC used to add a serverside contact, manages to add the contact to the list in a "Await Authorization"-state, which didn't happen before. This makes it possible to use the "Request Authorization"-menu entry of the contact, which sends an authorization request. After that is granted, the contact's status is shown correctly.

Problem:
 - It's ugly and doesn't belong there 
 - I didn't test what happens with contact that do not require authorization
 - Kopete doesn't show if a contact is offline or awaiting authorization
 - The "request authorization" dialog is not shown automatically

My knowledge of Kopete and Oscar code is not good enough to correct those, but maybe someone else can.
Comment 76 Casey Allen Shobe 2003-12-13 18:30:16 UTC
Subject: Re: [Kopete-devel]  Some online users are shown as offline

gerein@gmx.net (lau, desember 13 2003 06:17)
> Well, this bug is (originally at least) about ICQ

AIM and ICQ both use the same OSCAR protocol plugin.

> and there receiving messages from contacs not on your list works just fine
> (just tried it).

Yes, you can recieve them fine.  The only reason you can message them back is 
because ICQ supports offline messaging (Kopete thinks they're offline).  If 
you then add them to your list you cannot tell when they are online or not, 
but if you add them to your list *before* they message you, you can.

> You don't get a contact icon, but as long as the chat window is open you can
> send messages without problems. Is that really different with AIM?

Yes, because with AIM if you try to send a message you get a popup telling you 
you cannot message somebody who is not online, and your message is not sent.  
So your buddy sits there going "Hello??  Hellooo....?  I know you're there 
because you have a low idle.  Hellloooooo???  Are you ignoring me?  Fuck you 
then." so you go sign up for another AIM account and add them before 
messaging, then have to explain the whole situation to them and they say "Man 
that sounds like a shitty messenger.  You should use GAIM."

Comment 77 Casey Allen Shobe 2003-12-13 18:50:48 UTC
Subject: Re:  Some online users are shown as offline

> > You don't get a contact icon, but as long as the chat window is open you
> > can send messages without problems. Is that really different with AIM?

Another interesting scenario I just encountered.  I posted on a blog asking  
for people's IM accounts, and got the following response:

"my AIM is on privacy setting, so you'll have to tell me yours first."

Well now I have to explain to them that they need to tell me theirs first, so 
I can add it, then I can tell them mine, so they can add it, and then we 
might (?) be able to message each other if Kopete/OSCAR supports this (but I 
think it doesn't...and if not (I haven't yet tried) that may be the auth bug 
also being talked about here).

Comment 78 Jason Keirstead 2003-12-15 22:15:44 UTC
>WRONG. When an AIM user OR ICQ user messages me who is not on my list, I 
>cannot see their online presence (and thus on AIM I have no way to message 
>them). However I can add new AIM and ICQ users *just fine* without any 
>problems unless the remote ICQ user requires authorization (a different bug). 

No its not a different bug. It is all connected.

The current OSCAR plugin does not auto-add someone to the server list when they message you, because that person may need authorizaion. It is different with MSN, the MSN server itself adds the guy, the plugin does not need to. With OSCAR it is up to the client and Kopete doesn't do it for some reason.

So, even though this guy messages you, he is not on your server side list, you CAN NOT see his status. This is the problem. This is why if you add him in another client, or add him yourself BEFORE he messages you, it works fine.

HOWEVER, if he requires authorization, it STILL doesn't put him on the list until you click "Request Authorization" in the right click of him. If you DO do this though, it will work.

All the functionality is there, it's just not tied together properly.

Comment 79 Matt Rogers 2003-12-15 22:36:57 UTC
Now that I know mostly what is causing all this mess, I should be able to have a patch ready within the next two or three days.
Comment 80 Matt Rogers 2003-12-18 23:45:13 UTC
CVS commit by mattr: 

Fix bug 61223. Instead of just disregarding the fact that the client needs
authorization when we add them, resend the add request again, telling the 
ICQ server that we need authorization from the person on the other end.
The authorization message that is sent is blank to avoid conflict with the
string freeze.

Please note that contacts are still shown offline until they authorize your
request to add them to your contact list. This is inline with the behavior
of the official ICQ client. 

Also, contacts that are currently on your list are not affected by this patch.
You can right-click on the ICQ flower for that contact and click the 
"Request Authorization" button if it is enabled. If that button is greyed out,
you will have to remove the contact from your contact list and readd them again
after compiling Kopete with this patch.

CCMAIL: 61223-done@bugs.kde.org


Comment 81 Ismail Donmez 2003-12-19 08:58:32 UTC
I can't still request authorization from contacts that require auth. So I don't think this bug is fixed.
Comment 82 gerein 2003-12-19 11:05:59 UTC
> Please note that contacts are still shown offline until they authorize your 
> request to add them to your contact list. This is inline with the behavior 
> of the official ICQ client. 

Actually it's not. The official client (or ICQlite at least) shows contacts that are awaiting auth in a special "Awaiting authorization" state, in which they are greyed out instead of red like the offline contacts.

I think it's important to give the user this kind of visual feedback about the current state of it's contacts. There IS a big difference between "awaiting auth" and offline, so please reconsider the patch I sent to kopete-devel some days ago, which implements this additional status.
Comment 83 Matt Rogers 2003-12-19 16:51:55 UTC
cartman: are these newly added contacts or are they contacts you've already had on your list? 

gerrit: I'll probably commit a modification of your patch in the near future. I'd like to get a question mark overlay to go with it first though.
Comment 84 Ismail Donmez 2003-12-19 20:08:41 UTC
I was able to request auth. after restarting kopete. Weird but works! :)
Comment 85 Matt Rogers 2003-12-19 20:22:14 UTC
I think you might also be able to do it after logging off and logging back on, but I know for sure that it works if you restart kopete. Basically, a flag doesn't get set indicating that you need auth from that contact until a relogin occurs. I know about it, but i don't know if i'm going to be able to fix it with the contact list handling in its current state.
Comment 86 Charles Love 2003-12-20 02:44:53 UTC
im a bit lost. Isnt this bug about AOL too? If not, im looking at the wrong bug report. I notice that some AOL users who IM Me appear Offline, If I use AOL's Linux IM program they appear Online and I can talk to them through AIM. But not through Kopete..
Comment 87 Carsten Schlipf 2004-01-21 17:46:32 UTC
Sorry, but could it be that this bug is still existing in kopete delivered with 3.2RC1? Some ICQ contacts appear offline, while other users with other clients see these as online. These offline contacts even write messages to me and I can reply, but they still appear to be offline.
Comment 88 Andreas Bauer 2004-01-21 19:33:18 UTC
Hello together

I do have the same feeling that this bug isn't fixed. Tried it with several users some work, some don't. I do have the slight feeling (but can't prove it) that the authorization thing is maybe causing the problem. 
If you add a user with this wizard-dialog, it says at the end, that if the user requires authorization it will prompt you to do so. But this never happend.

I do know that kde3.2 is coming (which I would look very much forward to) that means a lot of work. Please, don't take me wrong, but to be honest, the standard KDE IM client not capable of talking to icq....

Let me know if I can help in any way (exept for code) and thank you for you work on this wounderfull KDE

Take care

&i
Comment 89 Marcelo Penna Guerra 2004-01-21 19:51:17 UTC
Ok, first, please make sure that the contacts exist on the SSI. You can check it on the debug output (starting Kopete on Konsole) or with another client.

Second, if your list is too big (aprox. 100 or more contacts), there's another bug report with a patch that was already commited on KDE_3_2_BRANCH, so you may try to use cvs, apply the patch or wait the next RC or final.

If all this fail, please post useful information like how to reproduce the bug and, most important of all, the debug output for the logon of the Oscar section (disable all other accounts and log to the account of the contact showing the problem). Also, tell what contacts appear offline. This will make it a *lot* easier to know what is causing the bug. 
Comment 90 Carsten Schlipf 2004-02-04 20:56:14 UTC
It only appears to happen to contacts, that are on the kopete list, but not on the server list. Obviously kopete somehow stopped to add new contacts to the server side but only added them locally.
Comment 91 Kenneth Krekula 2004-02-04 21:13:28 UTC
With Kopete 0.8 (the one that is included with KDE 3.2) the bug seems to be solved.
Comment 92 Ryan Sinn 2004-03-02 21:10:03 UTC
I am running Kopete 0.8 BRANCH >= 20040204 

... And I just encountered this problem.   A user was online using AIM and was sending me messages, but when I would try to respond Kopete would popup a dialog stating that I couldn't because the user was offline.  

I disconnected from AIM Protocol and reconnected... the user still offline and I received another message.

I closed the protocol again and started up GAIM.  The user was online was offline, but I could send and receive messages [GAIM let's the server determine whether or not the message can be sent -- apparently [according to other bugs/wishlist filed Kopete does it at the client level.]

I conversed with the user via GAIM.  Then closed GAIM, reconnected to AIM Protocol with Kopete and I could see the user.

I asked them if they were invisible or hiding and they said no.  I have no reason to believe they were lying and I don't even believe AIM has that feature.

I would suggest that this bug remain open as this still seems to be a problem.
Comment 93 Ryan Sinn 2004-03-02 21:13:09 UTC
I believe my last comment could be associated with this bug/wishlist item as well:

http://bugs.kde.org/show_bug.cgi?id=71306
Comment 94 G Narvaja 2004-03-10 03:29:01 UTC
Why is this bug closed when it is still there?
I'm using Kopete 0.7.3 (KDE 3.1.4)
I know the AIM user is online because he's sitting next to me on a 2nd computer.
Comment 95 Stefan Gehn 2004-03-10 10:03:31 UTC
> I'm using Kopete 0.7.3 (KDE 3.1.4) 
Because you are using an outdated version!
Comment 96 Ryan Sinn 2004-03-10 10:43:06 UTC
Well I'm Not Using An Outdated Version!
Comment 97 Jason Keirstead 2004-03-10 13:18:36 UTC
On March 10, 2004 5:43 am, Ryan Sinn wrote:
> ------- Additional Comments From ryan sinn org  2004-03-10 10:43 -------
> Well I'm Not Using An Outdated Version!

0.73 is very outdated. It was released almost 5 months ago ( a long time for 
non-gargantuan open source projects ).

0.74 was released in November and 0.8 was released in February, and KDE 3.2.1 
effectively has 0.8.1 in it ( though it is not a separate package yet )

Comment 98 Stefan Gehn 2004-03-10 15:39:45 UTC
I think we should close this bug, just the mass of different problems and the number of postings makes this bug useless.
There are two problems left:

- users who message you that are NOT on your contactlist yet won't get added to the serverside-contactlist automatically (try removing that temporary contact and add it through the wizard, so far this has worked reliable for me _everytime_)

- aim sucks because it does not support offline messages (unfixable)
Comment 99 Tom Schumm 2004-04-03 06:53:23 UTC
I'm still having this issue with Kopete 0.8.1 and ICQ.  All my ICQ users show up as offline.  I've tried removing and re-adding them, and re-requesting authorization - neither fixes the problem.
Comment 100 jsvrp.gw 2004-04-20 18:15:13 UTC
This BUG is NOT solved in KDE 3.2.2.

All ICQ users are showing offline , after a clean install.

Cheers,

Jeroen
Comment 101 Dominik Karall 2004-07-14 21:53:51 UTC
this bug isn't fixed in kde 3.2.3 too. in my contact list are still some users shown offline which should be online (i asked the users for their status). but with other users it works ok, only some users doesn't work correct.
using kopete version: 0.8.2
Comment 102 ieure 2004-08-13 08:52:51 UTC
"- users who message you that are NOT on your contactlist yet won't get added to the serverside-contactlist automatically (try removing that temporary contact and add it through the wizard, so far this has worked reliable for me _everytime_)"

I've seen this exact behavior. It sucks. Particularly when somebody sends a few messages a few seconds apart, and you're only partway through the add contact wizard. You have to cancel, delete the temporary contact again, and start over.

Also, I've noticed that if I change the contact name (Select contact, F2, new name), Kopete gets confused and the user will always show up as offline. Until they message me, that is, at which point I have to go through the process above and rename them, and regroup metacontacts.

This behavior is present as of 0.8.2 (in KDE 3.2.3). This bug needs to be reopened, it is /not/ fixed.
Comment 103 Till Gerken 2004-08-13 10:17:01 UTC
Is it still present in CVS HEAD / KDE_3_3_BRANCH though?
Comment 104 ieure 2004-09-15 09:16:28 UTC
I have observed the issue with renaming / metacontacts, though I haven't seen the original issue.
Comment 105 Emmeran Seehuber 2004-11-26 14:40:59 UTC
This bug is still present in Kopete 0.9.1 / KDE 3.3.1. I get "Status not available" for some ICQ contacts. The workaround through "Remove Contact&Add it again" works. When I just restart Kopete it still works. But the next day I start my computer&Kopete I get "Status not available" again. Maybe something in the ICQ server has been reseted over night?

I don't want to readd all my contacts everyday :( But I also don't want to switch to another ICQ client since the Kontact/KDE integration is very good and useful ....

Would you mind reopening the bug and trying to finally fix it?
Comment 106 Matt Rogers 2004-11-26 15:21:09 UTC
this bug is fixed. The problems you described have already been submitted as other bugs. (87714 would be a good example of another such bug)
Comment 107 Till 2005-06-30 20:06:34 UTC
I still experience this problem with current kopete from svn :-( pretty annoying. How can I help to solve this problem?
Comment 108 Jan Ritzerfeld 2005-06-30 20:42:35 UTC
I received an icq message from a contact not on my list. I moved it to "Friends" group but the contact never showed online. It was not stored on the server side list. Adding the contact via go.icq.com did the trick.
Comment 109 Dominik Schmidt 2005-06-30 20:47:02 UTC
@ jan:
yes, it's the icqlite trick ;)

so reopen this bug.. it's not fixed.. :\


but contacts who are added with the wizard are at least sometimes added to serversidecontactlist
Comment 110 Matt Rogers 2005-06-30 22:30:24 UTC
no, don't reopen this bug. add your comments, observations, etc. to bug 102399 instead. This bug is so old it's not worth adding even more comments to it.(which is why it's marked as CLOSED instead of RESOLVED). Please use 102399 instead.
Comment 111 Dexter Filmore 2005-09-30 14:20:17 UTC
I was just struck by amazement when I looked at the date of the first entry.

After 6 years of Linux I'm starting to doubt this open src thing a bit.
This has been going on for over two *years* whil gaim does the authorization absolutely smooth Readding contacts there and re-request authorization and accepting auth from within gaim makes contacts properly appear in kopete, too.

So I know, Gaim is organized differently, even written in a differetn lang (ObjC if I'm not all wrong), but would be so hard to ask the gaim devs how they do it and implement it in kopete? 
Comment 112 Dexter Filmore 2005-09-30 14:22:45 UTC
I was just struck by amazement when I looked at the date of the first entry.

After 6 years of Linux I'm starting to doubt this open src thing a bit.
This has been going on for over two *years* while gaim does the authorization absolutely smooth Readding contacts there and re-request authorization and accepting auth from within gaim makes contacts properly appear in kopete, too.

So I know, Gaim is organized differently, even written in a differetn lang (ObjC if I'm not all wrong), but would be so hard to ask the gaim devs how they do it and implement it in kopete? 
Comment 113 Ismail Donmez 2005-09-30 14:33:48 UTC
On Friday 30 September 2005 15:22, Dexter Filmore wrote:
[bugs.kde.org quoted mail]
-------
> I was just struck by amazement when I looked at the date of the first entry.
> 
> After 6 years of Linux I'm starting to doubt this open src thing a bit.
> This has been going on for over two *years* while gaim does the 

authorization absolutely smooth Readding contacts there and re-request 
authorization and accepting auth from within gaim makes contacts properly 
appear in kopete, too.
> 


Kopete is in need of programmers, nothing in open source world happens 
magically. So unless someone comes up and code it there won't be a proper 
authorization. So if you are interested in implementing this please come to 
irc.kde.org #kopete and there will be many people to get you started on 
coding for kopete.

> So I know, Gaim is organized differently, even written in a differetn lang 

(ObjC if I'm not all wrong), but would be so hard to ask the gaim devs how 
they do it and implement it in kopete?
> 

No its plain C.
Comment 114 Dexter Filmore 2005-09-30 14:49:10 UTC
sorry for the double post, mid-air collision.

Well, someone already *did* code it properly - the gaim people. So why reinvent the wheel?
Is the gaim code unportable? (No pointing fingers, I really don't know)
Comment 115 Ismail Donmez 2005-09-30 14:52:58 UTC
On Friday 30 September 2005 15:49, Dexter Filmore wrote:
[bugs.kde.org quoted mail]

Its not _easily_ portable. Recently I tried to port their oscar charset fix 
and things are really not same in Kopete compared to Gaim, and it takes time 
to port those fixes from Gaim to Kopete though its possible given enough time 
and knowledge.
Comment 116 Matt Rogers 2005-09-30 15:57:17 UTC
> ------- Additional Comments From Dexter.Filmore gmx de  2005-09-30 14:20 -------
> I was just struck by amazement when I looked at the date of the first entry.
> 


Yes, this bug is older, and i'm sure has been closed and reopened many
times.


> After 6 years of Linux I'm starting to doubt this open src thing a bit.
> This has been going on for over two *years* whil gaim does the authorization absolutely smooth Readding contacts there and re-request authorization and accepting auth from within gaim makes contacts properly appear in kopete, too.
> 


You should also consider the fact that gaim has been in development for
quite awhile longer than Kopete has, so of course they're going to have
more support for things.

> So I know, Gaim is organized differently, even written in a differetn lang (ObjC if I'm not all wrong), but would be so hard to ask the gaim devs how they do it and implement it in kopete?


I know how the gaim developers do it, and i know how the protocol works,
and i know how to implement it. Could you find some way to provide me
with more time so that I can get it finished? I'd also be happy to help
you out with it if you feel willing to learn C++ and Qt. 

Also, you should be aware that Kopete 0.11 will detect that contacts are
not on your serverside list and will prompt you to add to your list. So
hopefully, that will take care of one aspect of your problem.