Bug 59380

Summary: Please change kget taskbar icon when downloading
Product: [Applications] kget Reporter: Erik Schnetter <schnetter>
Component: generalAssignee: KGet bugs <kget-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Erik Schnetter 2003-06-05 13:09:15 UTC 
Version:           unknown (using KDE 3.1.2)
Installed from:     (testing/unstable)
Compiler:          gcc version 3.3 (Debian)
OS:          Linux (i686) release 2.4.20-3-686

(I do not know how to specify that this wish is for the kget application.  I could choose between many applications, but kget was not among them.  When I started the bug wizard, I thus selected "unknown" instead.)

I have a kget icon (the downward arrow) in my taskbar.  It would be nice if the arrow indicated whether a download is going on, or whether it has finished.  This way I would not have to open the kget application window to check.
Comment 1 Ferdinand Gassauer 2003-07-12 06:32:37 UTC 
Very true ;-)
Comment 2 Mohd Asif Ali Rizwaan 2003-12-20 00:51:45 UTC 
Agree, but please make it an option like:

OPTION:
[X] Display Download status: 
   ( ) Blink Icon
   ( ) Change Color [...] <- choose color 
   ( ) Change Icon  [...] <- choose icon
   (*) No Change
Comment 3 Falk Krönert 2004-03-27 02:02:21 UTC 
I suggest to let the icon fill up, depending, how much of the download is already completed. Either the Arrow itself or the icon around should be filled, not both. Personaly, I would prefer the icon.
Comment 4 Erik Schnetter 2004-05-10 21:14:23 UTC 
This is not yet done in KDE 3.2.2.
Comment 5 James Richard Tyrer 2004-08-26 01:39:35 UTC 
This idea has some merit.

However, I point out that it is possible to also place status indicators for individual downloads in the System Tray.

--
JRT
Comment 6 Leo Spalteholz 2005-05-10 09:16:18 UTC 
Amarok does the icon filling to show how far along a song is.  So perhaps the code for that could be lifted from there...  Just a thought.
Comment 7 Urs Wolfer 2005-07-24 16:30:31 UTC 
SVN commit 438157 by uwolfer:

Now the systrayicon change it's color when a download is in progress. I simply changed the arrow color to green (I'm not an artist... ;) ).

FEATURE: 50071
FEATURE: 59380

 M  +6 -0      docking.cpp  
 M  +1 -0      docking.h  
 AM            icons/cr22-action-kget_dock_download.png  
 M  +9 -0      kmainwidget.cpp  


--- trunk/KDE/kdenetwork/kget/docking.cpp #438156:438157
@@ -103,6 +103,12 @@
 }
 
 
+void DockWidget::changeIcon( const QString& icon )
+{
+    setPixmap( loadIcon( icon ));
+}
+
+
 DynamicTip::DynamicTip( QWidget * parent )
    : QToolTip( parent )
 {
--- trunk/KDE/kdenetwork/kget/docking.h #438156:438157
@@ -60,6 +60,7 @@
     ~DockWidget();
     /** No descriptions */
     void updateToolTip( const QString& );
+    void changeIcon( const QString& icon );
 
 
 
** trunk/KDE/kdenetwork/kget/icons/cr22-action-kget_dock_download.png #property changes
Name: svn:mime-type
   + application/octet-stream
--- trunk/KDE/kdenetwork/kget/kmainwidget.cpp #438156:438157
@@ -2111,6 +2111,15 @@
                  i18n("<br /><b>Time:</b> %1 ").arg(KIO::convertSeconds(remTime)) +
                  i18n("<br /><b>Speed:</b> %1/s").arg(KIO::convertSize(totalSpeed));
         kdock->updateToolTip( tmpstr );
+        //trayicon changes if download is in progress
+        if (totalSpeed == 0)
+        {
+            kdock->changeIcon( "kget_dock" );
+        }
+        else
+        {
+            kdock->changeIcon( "kget_dock_download" );
+        }
     }
 #ifdef _DEBUG
     //sDebugOut << endl;