| Summary: | Missing some useful C++ warning options | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Chris Thompson <chris> |
| Component: | general | Assignee: | KDevelop Developers <kdevelop-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version: | 3.0.0a4 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Patch to change warnings tab headers | ||
|
Description
Chris Thompson
2003-04-11 02:11:19 UTC
Fixed in CVS by Alexander Dymo <cloudtemple at mksat dot net> Would like this bug reopened. All of the requested modifications I had with one exception have been added, and I thank you. While you are right that the -Wall functionality is implicit, I would like this actually STATED. That is, I would like the wording to change from: 'All warnings below, combined' to: 'All warnings below, combined (-Wall)' It was not clear to me that this is what the checkbox does. Additionally, it would be useful to somehow indicate that the Warnings I page contains the 'safe' warnings, i.e. warnings contained in -Wall, and that the Warnings II page contains options that do not fit into gcc's definition of 'warnings about constructions that some users consider questionable, and that are easy to avoid (or modify to prevent the warnings), even in conjunction with macros' (from gcc info page). I do not know the best way to notify the user that this is the intention of the Warnings I and Warnings II pages but I did not realise this until today. Added the (-Wall) text Yay! This is great! As noted, I would quite like 'Warnings I' renamed as 'Warnings (safe)' and 'Warnings II' renamed as 'Warnings (unsafe)' or something similar. If necessary, I can submit a patch to do this, though it should be obvious I don't have particularly good wording here. :) In any case, thanks for this fix. Created attachment 1637 [details]
Patch to change warnings tab headers
This is a patch to change the title on the warnings tabs. My wording is not
particularly good and I'm hoping someone else can think of something better.
This is an update to note that this bug still applies to 3.0a5 and the attached patch would still resolve the remainder of this bug. Subject: kdevelop/plugins/gccoptions CVS commit by aclu: renamed 'Warnings I' as 'Warnings (safe)' renamed 'Warnings II' as 'Warnings (unsafe)' Thanks to: Chris Thompson (chris in hypocrite.org) CCMAIL: 57116-done@bugs.kde.org M +2 -2 gccoptionsplugin.cpp 1.14 --- kdevelop/plugins/gccoptions/gccoptionsplugin.cpp #1.13:1.14 @@ -569,8 +569,8 @@ GccOptionsDialog::GccOptionsDialog(GccOp g77 = 0; - vbox = addVBoxPage(i18n("Warnings I")); + vbox = addVBoxPage(i18n("Warnings (safe)")); warnings1 = new Warnings1Tab(type, vbox, "warnings1 tab"); - vbox = addVBoxPage(i18n("Warnings II")); + vbox = addVBoxPage(i18n("Warnings (unsafe)")); warnings2 = new Warnings2Tab(type, vbox, "warnings2 tab"); } Took me ages to find out what the difference between 'Safe' warnings and 'Unsafe' warnings are. This is possibly the worst relabelling ever! I'm still not sure. I assume 'Safe' warnings are warnings that you should use, but 'Unsafe' ones are more likely warn you for things that are actually correct. Please either add some extra text somewhere explaining this *in the dialog*, or relabel them to something like "Recommended Warnings", "Paranoid Warnings". Also, it would be highly desirable to add some text explaining what each of the -W<something> options does as I have no idea from the dialog. |