Bug 56840

Summary: Konqueror tortures X11 on Out Of Disk space
Product: [Applications] konqueror Reporter: Charles Samuels <charles>
Component: bookmarksAssignee: Konqueror Bugs <konqueror-bugs-null>
Status: RESOLVED FIXED    
Severity: crash    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Charles Samuels 2003-04-04 18:28:15 UTC 
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

If you run out of disk space, and visit a web site, it'll say "can't write bookmarks.xml - out of disk space".  Problem is that it shows this in a dialog box, and it will show an endless supply of these dialog boxes, thereby DoSing your X server, and pissing off kwin & kicker's taskbar in the process.  I think you should just ignore this problem silently.

Why does it write to the bookmarks file when you're just browsing, anyway?
Comment 1 lypanov 2003-07-06 16:00:41 UTC 
Subject: kdelibs/kio/bookmarks

CVS commit by lypanov: 

Only show "can't write bookmarks.xml - out of disk space" 
once to prevent DoS'ing of the users screen. Also improve
the error message slightly, though i guess it could be
possible duplication of data: "out of disk space"
CCMAIL: 56840-done@bugs.kde.org


  M +11 -1     kbookmarkmanager.cc   1.65


--- kdelibs/kio/bookmarks/kbookmarkmanager.cc  #1.64:1.65
@@ -265,5 +265,15 @@ bool KBookmarkManager::saveAs( const QSt
 
 failure:
-    KMessageBox::error( 0L, i18n("Couldn't save bookmarks in %1. %2").arg(filename).arg(strerror(file.status())) );
+    static int hadSaveError = false;
+    if ( !hadSaveError )
+        KMessageBox::error( 
+            0L, i18n("Couldn't save bookmarks in %1. Reported error was: %2."
+                     "This error message will only be shown once, please fix the "
+                     "possible cause of the error as quickly as possible, "
+                     "the most likely cause is that of a full harddrive")
+                .arg(filename)
+                .arg(strerror(file.status())) 
+        );
+    hadSaveError = true;
     return false;
 }