Bug 56669

*** Bug 59240 has been marked as a duplicate of this bug. ***

*** Bug 76340 has been marked as a duplicate of this bug. ***

*** Bug 76894 has been marked as a duplicate of this bug. ***

I think that it is a bug, as KCalc does not use at all the locale settings, for example for the decimal symbol.

Have a nice day!

*** Bug 79599 has been marked as a duplicate of this bug. ***

At this time, KCalc uses '.' as decimal separator, so inserting thousand separator may cause inconsistences. I'm working on changing the decimal separator to the symbol specified in the locale preferences. This is the first step in order to fix this bug.

CVS commit by hierro: 

Changed the decimal separator, know it honors the
global locale settings. First step for fixing bug #56669.
CCMAIL:56669@bugs.kde.org


  M +1 -1      kcalc.cpp   1.164
  M +41 -21    kcalcdisplay.cpp   1.17

CVS commit by hierro: 

Changed decimal separator to the symbol specified in the locale
settings. Added thousands separators based on locale settings too.
Fixes bug #56669.
CCMAIL:56669-done@bugs.kde.org


  M +51 -3     kcalcdisplay.cpp   1.20
  M +1 -0      kcalcdisplay.h   1.11


--- kdeutils/kcalc/kcalcdisplay.cpp  #1.19:1.20
@@ -29,4 +29,5 @@
 #include <qclipboard.h>
 
+#include <kglobal.h>
 #include <klocale.h>
 #include <knotifyclient.h>
@@ -276,6 +277,53 @@ bool KCalcDisplay::setAmount(CALCAMNT ne
 void KCalcDisplay::setText(QString const &string)
 {
-        QLabel::setText(string);
-        emit changedText(string);
+        QString localizedString = string;
+        
+        // If we aren't in decimal mode, we don't need to modify the string
+        if (_num_base == NB_DECIMAL)
+        {
+                // Obtain decimal symbol and thousands separator
+                QString decimalSymbol = KGlobal::locale()->decimalSymbol();
+                QString thousandsSeparator = KGlobal::locale()->thousandsSeparator();
+        
+                // Replace dot with locale decimal separator
+                localizedString.replace(QChar('.'),decimalSymbol);
+        
+                // Insert the thousand separators
+                int i = localizedString.find(decimalSymbol) != -1? localizedString.find(decimalSymbol)-1: localizedString.length()-1;
+                for(int j=1;i>0;i--,j++)
+                        if (j%3 == 0)
+                                localizedString.insert(i,thousandsSeparator);
+        }
+
+        QLabel::setText(localizedString);
+        emit changedText(localizedString);
+}
+
+QString KCalcDisplay::text() const
+{
+        if (_num_base != NB_DECIMAL)
+                return QLabel::text();
+        
+        QString unlocalizedString = QLabel::text();
+        
+        // Obtain decimal symbol and thousands separator
+        QString decimalSymbol = KGlobal::locale()->decimalSymbol();
+        QString thousandsSeparator = KGlobal::locale()->thousandsSeparator();
+
+        // TODO: This may cause problems if the user
+        // sets decimalSymbol == thousandsSeparator
+        // Since text() is only used for prepending
+        // other text in NB_HEX mode and measuring
+        // the display lenght, this is not a big
+        // problem. Anyway, we should find a 
+        // better way of doing this.
+
+        // Delete thousands separators  
+        unlocalizedString.remove(thousandsSeparator);
+        
+        // Replace decimalSymbol with '.'
+        unlocalizedString.replace(decimalSymbol,QChar('.'));
+        
+        return unlocalizedString;
 }
 

--- kdeutils/kcalc/kcalcdisplay.h  #1.10:1.11
@@ -108,4 +108,5 @@ public:
         void setPrecision(int precision);
         void setText(QString const &string);
+        QString text() const;
         bool updateDisplay(void);
 private:

I'm away from kde but this change looks to only consider decimal mode. I'd like for grouping to work with binary as well. Somewhat like this: "1011 0011 1111 1111"  etc ...  This is what I was hoping for actually :)  New wish?

Roger: Please, file a bug report and assign it to me. I will take care as soon as possible.

Created attachment 8437 [details]
digits grouping in binary, decimal and hexadecimal mode.

Bug not resolved using kcalc 1.6 and KDE 3.3.2 on Debian (testing).  
The locale is used for the "keypad" part of the display, but not for the number you are working on - which tends to be where you look, anyway!  
The decimal point shows correctly on the "keypad" but not for the number displayed, and the thousands separator isn't used for the number displayed at all.

What version of Kcalc has the patch?  Or has it been released yet?

[ ex
Bug seems not resolved using kcalc 2.0.6 under Slackware 12.1 with locale ru_RU.utf8.  
The locale is not used neither for the "keypad" part of the display, nor for the number. For example, I see now 31,557,600.0000000000 in place of 31 557 600,00000000000.
This can be also bug of Slackware 12.1: when I start kcalc and many other applications from terminal emulator, I see the next message: "Qt: Locales not supported on X server". But applications use language that corresponds to locale.

The message "Qt: Locales not supported on X server" was because of my error: locale should not be "ru_RU.utf8", but "ru_RU.UTF-8". I set locale to this correct value and have no this warning now. But bug in kcalc still here.

I try also kcalc in Mandriva 2009.0 (kde4). It has this ignore-locale bug too.