Bug 56307

Summary: Show the character encoding in "View Document Information"
Product: [Applications] konqueror Reporter: Torquil Macdonald Sørensen <torquil>
Component: generalAssignee: George Staikos <staikos>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Torquil Macdonald Sørensen 2003-03-24 11:08:13 UTC 
Version:           unknown (using KDE 3.1.1)
Installed from:     (testing/unstable)
Compiler:          gcc version 3.2.3 20030309 (Debian prerelease)
OS:          Linux (i686) release 2.4.21-pre5

It would be nice to be able to see what character encoding the web page uses by looking at "View Document Information" on the "View" menu. Btw, the menu item is called "View Document Information", but the title on the window that appears when I click on it says "Page Information". Maybe these should be the same.
Comment 1 George Staikos 2003-08-30 23:53:53 UTC 
Subject: kdelibs/khtml

CVS commit by staikos: 

Half of #56307

CCMAIL: 56307@bugs.kde.org


  M +1 -1      htmlpageinfo.ui   1.7


--- kdelibs/khtml/htmlpageinfo.ui  #1.6:1.7
@@ -24,5 +24,5 @@
     </property>
     <property name="caption">
-        <string>Page Information</string>
+        <string>Document Information</string>
     </property>
     <grid>
Comment 2 George Staikos 2004-11-18 22:49:28 UTC 
CVS commit by staikos: 

Show the character set in the page info dialog.
FEATURE: 56307


  M +32 -0     htmlpageinfo.ui   1.9
  M +7 -0      khtml_part.cpp   1.1052


--- kdelibs/khtml/htmlpageinfo.ui  #1.8:1.9
@@ -145,4 +145,36 @@
                             </property>
                         </widget>
+                        <widget class="QLabel" row="3" column="0">
+                            <property name="name">
+                                <cstring>_eLabel</cstring>
+                            </property>
+                            <property name="sizePolicy">
+                                <sizepolicy>
+                                    <hsizetype>0</hsizetype>
+                                    <vsizetype>0</vsizetype>
+                                    <horstretch>0</horstretch>
+                                    <verstretch>0</verstretch>
+                                </sizepolicy>
+                            </property>
+                            <property name="text">
+                                <string>Document encoding:</string>
+                            </property>
+                            <property name="buddy" stdset="0">
+                                <cstring>_encoding</cstring>
+                            </property>
+                        </widget>
+                        <widget class="KActiveLabel" row="3" column="1">
+                            <property name="name">
+                                <cstring>_encoding</cstring>
+                            </property>
+                            <property name="sizePolicy">
+                                <sizepolicy>
+                                    <hsizetype>7</hsizetype>
+                                    <vsizetype>5</vsizetype>
+                                    <horstretch>1</horstretch>
+                                    <verstretch>0</verstretch>
+                                </sizepolicy>
+                            </property>
+                        </widget>
                     </grid>
                 </widget>

--- kdelibs/khtml/khtml_part.cpp  #1.1051:1.1052
@@ -3691,4 +3691,11 @@ void KHTMLPart::slotViewPageInfo()
     dlg->_lastModified->setText(lastModified());
 
+  const QString& enc = encoding();
+  if (enc.isEmpty()) {
+    dlg->_eLabel->hide();
+    dlg->_encoding->hide();
+  } else {
+    dlg->_encoding->setText(enc);
+  }
   /* populate the list view now */
   const QStringList headers = QStringList::split("\n", d->m_httpHeaders);