Bug 55645

Summary: Open Messages window when action executed
Product: [Unmaintained] quanta Reporter: Ted Pibil <ted>
Component: generalAssignee: András Manţia <amantia>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: RedHat Enterprise Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Ted Pibil 2003-03-07 15:58:56 UTC 
Version:            (using KDE KDE 3.1)
Installed from:    RedHat RPMs
Compiler:          gcc (GCC) 3.2.1 20030202 (Red Hat Linux 8.0 3.2.1-7) 
OS:          Linux

When an action writes output to the Messages window, is it possible to have Quanata check to see if the Messages Window is currently open, and if not, open it to show output.  

Currently, if you click on an action and expect to see output, end users may think that nothing happened because there was no viewable output.
Comment 1 András Manţia 2003-03-14 11:36:50 UTC 
Subject: quanta

CVS commit by amantia: 

Bring up the message output window, when and action/plugin wants to printed some message. Implements wish #55645.

CCMAIL: 55645-done@bugs.kde.org


  M +2 -0      ChangeLog   1.138
  M +0 -1      quanta/messages/messageoutput.cpp   1.20
  M +15 -15    quanta/messages/messageoutput.h   1.11
  M +5 -0      quanta/plugins/quantacmdplugin.cpp   1.17
  M +15 -3     quanta/quanta.cpp   1.240
  M +1 -1      quanta/quanta.h   1.125
  M +5 -0      quanta/toolbar/tagaction.cpp   1.35


--- quanta/ChangeLog  #1.137:1.138
@@ -42,4 +42,6 @@
         - Message Frame
     - reworked Configure Actions dialog
+    - bring up the message output window, when and action/plugin wants to printed
+      some message. Implements wish #55645.
   - new DCOP interfaces:
   - changed behavior:

--- quanta/quanta/quanta.cpp  #1.239:1.240
@@ -1274,9 +1274,21 @@ void QuantaApp::slotShowTTabDock() { tta
 void QuantaApp::slotShowSTabDock() { stabdock->changeHideShowState();}
 void QuantaApp::slotShowDTabDock() { dtabdock->changeHideShowState();}
-void QuantaApp::slotShowBottDock()
+void QuantaApp::slotShowBottDock(bool force)
 {
   if ( bottdock->parent() == 0L )
+  {
        bottdock->manualDock(maindock, KDockWidget::DockBottom, 80);
-  else bottdock->changeHideShowState();
+    showMessagesAction->setChecked(true);
+  }
+  else
+  {
+    if (!force)
+        bottdock->changeHideShowState();
+    else
+    {
+      showMessagesAction->setChecked(true);
+      bottdock->show();
+    }
+  }
 }
 

--- quanta/quanta/quanta.h  #1.124:1.125
@@ -218,5 +218,5 @@ public slots:
   void slotViewRepaint();
 
-  void slotShowBottDock();
+  void slotShowBottDock(bool force = false);
   void slotShowFTabDock();
   void slotShowPTabDock();

--- quanta/quanta/messages/messageoutput.h  #1.10:1.11
@@ -4,5 +4,5 @@
     begin                : Thu Feb 24 2000
     copyright            : (C) 2000 by Yacovlev Alexander & Dmitry Poplavski
-                           (C) 2002 Andras Mantia <amantia@freemail.hu>
+                           (C) 2002,2003 Andras Mantia <amantia@freemail.hu>
     email                : pdima@mail.univ.kiev.ua
  ***************************************************************************/

--- quanta/quanta/plugins/quantacmdplugin.cpp  #1.16:1.17
@@ -138,4 +138,9 @@ bool QuantaCmdPlugin::run()
     connect(m_process, SIGNAL(receivedStderr(KProcess *, char *, int)), SLOT(writeStderr(KProcess *, char *, int)));
     connect(m_process, SIGNAL(processExited(KProcess *)), SLOT(cleanupProcess(KProcess *)));
+    if(outputWindow() == i18n("Message Window"))
+    {
+      quantaApp->slotShowBottDock(true);
+    }
+
     if(!m_process->start(KProcess::NotifyOnExit, KProcess::AllOutput))
     {

--- quanta/quanta/toolbar/tagaction.cpp  #1.34:1.35
@@ -164,4 +164,9 @@ void TagAction::insertTag()
                  SLOT(  slotGetScriptError(KProcess*,char*,int)));
 
+    if (scriptOutputDest == "message" || scriptErrorDest == "message")
+    {
+      quantaApp->slotShowBottDock(true);
+    }
+
     if (proc->start(KProcess::NotifyOnExit, KProcess::All))
     {