| Summary: | The Dynamic Launcher Portal does not have a button to accept the proposed launcher | ||
|---|---|---|---|
| Product: | [Plasma] xdg-desktop-portal-kde | Reporter: | Ryan Brue <ryanbrue.dev> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, kde, kdebugs, kdedev, nate, realkpavel |
| Priority: | HI | ||
| Version First Reported In: | 6.6.2 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/b67b6e092e4109941e57915f59f40db0b9d60fec | Version Fixed/Implemented In: | 6.6.5 |
| Sentry Crash Report: | |||
| Attachments: | The dialog that shows up when triggering the dynamic launcher portal. | ||
|
Description
Ryan Brue
2026-05-01 00:35:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/552 Git commit f07493b7ffb6423fea0fe3db157203693a3299a8 by Nate Graham. Committed on 08/05/2026 at 13:28. Pushed by ngraham into branch 'master'. PortalDialog: fix standard button handling The top-level standardButtons property was aliased to something in a component, which then referred back to the top-level property! And the whole button box would only be visible if any of its own buttons were shown (not taking into account custom buttons). This was fine in cases where implementations specified which buttons they wanted, but failed in the case where they wanted none and also specified their own set of custom actions. Untangle this by specifying default buttons in the top-level property and making visibility take into account custom actions. As a cleanup, now we can remove all the requests for the standard buttons in the implementations (they'll fall back to the defaults). FIXED-IN: 6.6.5 M +0 -2 src/AccessDialog.qml M +2 -0 src/DynamicLauncherDialog.qml M +0 -1 src/GlobalShortcutsDialog.qml M +0 -2 src/InputCaptureDialog.qml M +2 -2 src/PortalDialog.qml M +0 -2 src/RemoteDesktopDialog.qml M +0 -2 src/ScreenshotDialog.qml M +0 -2 src/UsbDialog.qml M +0 -2 src/UserInfoDialog.qml M +0 -2 src/WallpaperDialog.qml https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/f07493b7ffb6423fea0fe3db157203693a3299a8 Git commit b67b6e092e4109941e57915f59f40db0b9d60fec by Nate Graham. Committed on 08/05/2026 at 14:27. Pushed by ngraham into branch 'Plasma/6.6'. PortalDialog: fix standard button handling The top-level standardButtons property was aliased to something in a component, which then referred back to the top-level property! And the whole button box would only be visible if any of its own buttons were shown (not taking into account custom buttons). This was fine in cases where implementations specified which buttons they wanted, but failed in the case where they wanted none and also specified their own set of custom actions. Untangle this by specifying default buttons in the top-level property and making visibility take into account custom actions. As a cleanup, now we can remove all the requests for the standard buttons in the implementations (they'll fall back to the defaults). FIXED-IN: 6.6.5 (cherry picked from commit f07493b7ffb6423fea0fe3db157203693a3299a8) a60e8955 PortalDialog: fix standard button handling Co-authored-by: Nate Graham <nate@kde.org> M +0 -2 src/AccessDialog.qml M +2 -0 src/DynamicLauncherDialog.qml M +0 -1 src/GlobalShortcutsDialog.qml M +0 -2 src/InputCaptureDialog.qml M +2 -2 src/PortalDialog.qml M +0 -2 src/RemoteDesktopDialog.qml M +0 -2 src/ScreenshotDialog.qml M +0 -2 src/UsbDialog.qml M +0 -2 src/UserInfoDialog.qml M +0 -2 src/WallpaperDialog.qml https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/b67b6e092e4109941e57915f59f40db0b9d60fec *** Bug 517124 has been marked as a duplicate of this bug. *** |