| Summary: | Distinguish between realloc functions in realloc size 0 error messages | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Paul Floyd <pjfloyd> |
| Component: | memcheck | Assignee: | Paul Floyd <pjfloyd> |
| Status: | REPORTED --- | ||
| Severity: | normal | CC: | mark |
| Priority: | NOR | ||
| Version First Reported In: | 3.27 GIT | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
initial patch, FreeBSD only
Patch with Linux expecteds Revised patch |
||
|
Description
Paul Floyd
2026-02-08 17:34:53 UTC
Created attachment 189359 [details]
initial patch, FreeBSD only
Need to run on Linux to update the expecteds there
Created attachment 189360 [details]
Patch with Linux expecteds
Also fixed a warning
(In reply to Paul Floyd from comment #2) > Created attachment 189360 [details] > Patch with Linux expecteds > > Also fixed a warning I think this should be fine since no error kinds are really changed, just the message printed. So suppressions should still work as is? You might want to also put static const HChar* reallocKinds[] into pub_tool_tooliface.h in case other tools might want to print the actual function name. (In reply to Mark Wielaard from comment #3) > (In reply to Paul Floyd from comment #2) > > Created attachment 189360 [details] > > Patch with Linux expecteds > > > > Also fixed a warning > > I think this should be fine since no error kinds are really changed, just > the message printed. So suppressions should still work as is? Ues, the suppressions use "ReallocSizeZero" which I'm not going to change. > You might want to also put static const HChar* reallocKinds[] into > pub_tool_tooliface.h in case other tools might want to print the actual > function name. Hmm. Thinking of other tools maybe I can use hasfn = VG_(get_fnname)(ai->Addr.Stack.epoch, ai->Addr.Stack.IP, &fn); then I could leave the error struct alone, it already has struct { AddrInfo ai; } ReallocSizeZero; Created attachment 189446 [details]
Revised patch
I've changed approach and added a new function that gets the first function name from an ExeContext. This is much less pervasive a change.
It could also be be extended to the fishy and aligned memcheck errors which use generalised names that don't distinguish between nothrow(true) and nothrow(false) operator new overloads. That might not be entirely a bad thing.
|