| Summary: | Unable to re-pick the same color after deleting it | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Erika <hataraku-kde> |
| Component: | Color Picker widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, nate |
| Priority: | NOR | ||
| Version First Reported In: | 6.5.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kdeplasma-addons/-/commit/1b2603d19a8585ae1439d2d5174bbe0936bff90a | Version Fixed/Implemented In: | 6.6.0 |
| Sentry Crash Report: | |||
|
Description
Erika
2026-01-23 17:35:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/987 Git commit 016448f4d3058bb02bd04e1f58197367f8b870b6 by Christoph Wolk. Committed on 26/01/2026 at 17:19. Pushed by cwo into branch 'master'. applets/colorpicker: always send currentColorChanged GrabWidget returns early if the currentColor is changed to the same color it already is. While this is usually a good idea, it's not here – the color being set only happens when the user has completed picking a color, and the widget needs to be informed about this. There's some extra deduplicating logic there anyway, and re-picking the same color is legitimate - the user may do this to copy it to the clipboard again, or may have deleted it from the history, then reconsidered and now try to re-add it by picking the same color again. Instead, don't return early if unchanged, and always send the Changed signal. FIXED-IN: 6.6.0 M +2 -3 applets/colorpicker/grabwidget.cpp https://invent.kde.org/plasma/kdeplasma-addons/-/commit/016448f4d3058bb02bd04e1f58197367f8b870b6 Git commit 1b2603d19a8585ae1439d2d5174bbe0936bff90a by Christoph Wolk. Committed on 26/01/2026 at 19:09. Pushed by cwo into branch 'Plasma/6.6'. applets/colorpicker: always send currentColorChanged GrabWidget returns early if the currentColor is changed to the same color it already is. While this is usually a good idea, it's not here – the color being set only happens when the user has completed picking a color, and the widget needs to be informed about this. There's some extra deduplicating logic there anyway, and re-picking the same color is legitimate - the user may do this to copy it to the clipboard again, or may have deleted it from the history, then reconsidered and now try to re-add it by picking the same color again. Instead, don't return early if unchanged, and always send the Changed signal. FIXED-IN: 6.6.0 (cherry picked from commit 016448f4d3058bb02bd04e1f58197367f8b870b6) Co-authored-by: Christoph Wolk <cwo.kde@posteo.net> M +2 -3 applets/colorpicker/grabwidget.cpp https://invent.kde.org/plasma/kdeplasma-addons/-/commit/1b2603d19a8585ae1439d2d5174bbe0936bff90a |