| Summary: | SPDX-FileCopyrightText lines are very long | ||
|---|---|---|---|
| Product: | [Applications] lokalize | Reporter: | Philipp Kiemle <l10n.daphipz> |
| Component: | editor | Assignee: | Finley Watson <fin-w> |
| Status: | REPORTED --- | ||
| Severity: | normal | CC: | aacid, karl, sdepiets, shafff |
| Priority: | NOR | ||
| Version First Reported In: | 25.08.3 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Philipp Kiemle
2026-01-11 20:22:16 UTC
Thanks for the report. Is there a standard for these lines? I meant specific to the format of SPDX-FileCopyrightText, for instance I don't want to change this line and then tooling that consumes the line breaks because the new format is unexpected. 8.8 says it's free form https://spdx.github.io/spdx-spec/v2.3/file-information/ (In reply to Finley Watson from comment #3) > I meant specific to the format of SPDX-FileCopyrightText, for instance I > don't want to change this line and then tooling that consumes the line > breaks because the new format is unexpected. I found these two sources: - https://reuse.software/spec-3.3/#format-of-copyright-notices - https://spdx.github.io/spdx-spec/v2.3/file-tags/ They both say that the proposed version is OK. So every tooling dealing with these lines *should* be able to parse them either way, I guess Thanks both. I'll bear this bug in mind for a potential port to using libgettext instead of the handmade stuff Lokalize currently uses. In the mean time, I've found where the logic needs updating: https://invent.kde.org/sdk/lokalize/-/blob/master/src/catalog/gettextheaderparser.cpp?ref_type=heads#L75 (In reply to Philipp Kiemle from comment #0) > # SPDX-FileCopyrightText: 2006, 2010, 2011, 2012, 2013, 2014, 2015, 2017, > 2018, 2019, 2020, 2021 Firstname Lastname <email@domain.tld> > > I think it would be better if "adjacent" years would be summarized into a > range, so the above line would become > > # SPDX-FileCopyrightText: 2006, 2010-2021 Firstname Lastname > <email@domain.tld> This looks wrong. Since the year 2016 is missing in the first list, I think the ranges should be: 2006, 2010-2015, 2017-2021 Yeah, you are right - I didn't see it was missing. |