| Summary: | Add SSE4.1 PMULLD instruction for x86 32 bit | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Alexandra Hajkova <ahajkova> |
| Component: | general | Assignee: | Alexandra Hajkova <ahajkova> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mark |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
patch
patch patch |
||
|
Description
Alexandra Hajkova
2025-12-17 12:19:21 UTC
Created attachment 187731 [details]
patch
Support pmulld (packed multiply 32-bit doubleword integers) instruction
in guest_x86_toIR.c and host_x86_isel.c. Add test function to
sse4-common.h and update none/tests/x86/sse4-x86.c to test the
instruction.
Created attachment 187733 [details]
patch
So this looks good. Then only real difference with the amd64 implementation is that in case of an address there is a gen_SIGNAL_if_not_16_aligned. For the test you have to remove the test_PMULLD from sse4-64.c since it now is in sse4-common.h. Created attachment 187734 [details]
patch
(In reply to Alexandra Hajkova from comment #4) > Created attachment 187734 [details] > patch Looks good to me. Has NEWS entry added and ./none/tests/x86/sse4-x86 work the same with/without valgrind. Please push. |