Bug 513240

Summary: Build failed on core/libs/properties/itemsgroupedviewtoolbar.cpp with QT5 compatibilty error
Product: [Applications] digikam Reporter: pascal lacroix <kikoucalou>
Component: Portability-CompilationAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: 9.0.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 9.0.0
Sentry Crash Report:

Description pascal lacroix 2025-12-12 08:16:08 UTC
Build failled with error :

``` text* In file included from /mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.cpp:15:
/mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.h:38:21: error: 'QEnterEvent' has not been declared
   38 |     void enterEvent(QEnterEvent *event) override;
      |                     ^~~~~~~~~~~
/mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.h:38:10: error: 'void Digikam::ItemsGroupedViewToolbar::enterEvent(int*)' marked 'override', but does not override
   38 |     void enterEvent(QEnterEvent *event) override;
      |          ^~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QWidget:1,
                 from /mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.h:19:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:631:18: warning: 'virtual void QWidget::enterEvent(QEvent*)' was hidden [-Woverloaded-virtual=]
  631 |     virtual void enterEvent(QEvent *event);
      |                  ^~~~~~~~~~
/mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.h:38:10: note:   by 'void Digikam::ItemsGroupedViewToolbar::enterEvent(int*)'
   38 |     void enterEvent(QEnterEvent *event) override;
      |          ^~~~~~~~~~
/mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.cpp:55:6: error: variable or field 'enterEvent' declared void
   55 | void ItemsGroupedViewToolbar::enterEvent(QEnterEvent* event)
      |      ^~~~~~~~~~~~~~~~~~~~~~~
/mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.cpp:55:42: error: 'QEnterEvent' was not declared in this scope; did you mean 'QTimerEvent'?
   55 | void ItemsGroupedViewToolbar::enterEvent(QEnterEvent* event)
      |                                          ^~~~~~~~~~~
      |                                          QTimerEvent
/mnt/2c98cfab-4320-4ff2-b8d7-f2da522cc741/digikam-devel/mygit/digikam-8.8.0-dev-202512120836/core/libs/properties/itemsgroupedviewtoolbar.cpp:55:55: error: 'event' was not declared in this scope; did you mean 'QEvent'?
   55 | void ItemsGroupedViewToolbar::enterEvent(QEnterEvent* event)
      |                                                       ^~~~~
      |                                                       QEvent
make[3]: *** [core/libs/properties/CMakeFiles/gui_itempropertiesdigikam_obj.dir/build.make:228: core/libs/properties/CMakeFiles/gui_itempropertiesdigikam_obj.dir/itemsgroupedviewtoolbar.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs.... ```

Root cause:
The code uses QEnterEvent which was introduced in Qt 6, but the compilation environment uses Qt 5. In Qt 5, the appropriate event type is QEvent (specifically QEvent::Enter).

Affected files:

core/libs/properties/itemsgroupedviewtoolbar.h

core/libs/properties/itemsgroupedviewtoolbar.cpp

SOFTWARE/OS VERSIONS
Linux Mint 22-2
Environnement de développement de KDE 
Version 5.115.0
Qt 
Version 5.15.13 (Compilé avec 5.15.13)

ADDITIONAL INFORMATION

My last fine build was from commit : 9a31bbac
Comment 1 caulier.gilles 2025-12-13 08:36:46 UTC
Git commit 5d381f96c204ced9a783e9e693a919780da1fe64 by Gilles Caulier.
Committed on 13/12/2025 at 08:33.
Pushed by cgilles into branch 'master'.

first approach to use a toolbar over the Grouped items tree-view. Only one action is implmented : remove item from the stack

M  +1    -1    core/libs/properties/CMakeLists.txt
A  +58   -0    core/libs/properties/itemsgroupedtoolbar.cpp     [License: GPL(v2.0+)]
R  +5    -7    core/libs/properties/itemsgroupedtoolbar.h [from: core/libs/properties/itemsgroupedviewtoolbar.h - 072% similarity]
M  +83   -18   core/libs/properties/itemsgroupedview.cpp
M  +3    -0    core/libs/properties/itemsgroupedview.h
D  +0    -69   core/libs/properties/itemsgroupedviewtoolbar.cpp

https://invent.kde.org/graphics/digikam/-/commit/5d381f96c204ced9a783e9e693a919780da1fe64