| Summary: | Deleting files from disk adds them to the blocklist | ||
|---|---|---|---|
| Product: | [Applications] kphotoalbum | Reporter: | Andreas Schleth <schleth_es> |
| Component: | general | Assignee: | KPhotoAlbum Bugs <kphotoalbum-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | rsquared42 |
| Priority: | NOR | ||
| Version First Reported In: | GIT master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/kphotoalbum/-/commit/9e7cdfcd9df125b585d874492db89a0ef6e4a034 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Andreas Schleth
2025-11-16 17:26:38 UTC
Thank you for reporting this, Andreas. So far I am unable to reproduce this with the demo. However, I do see files in the blocklist in my personal album and I'm sure I didn't block them deliberately. Are you able to reproduce this with the demo? Hi Randall, I just built a new KPA from git and cannot reproduce this issue with the demo and with one of my databases. However I had a lot images in the blocklist without intending to. Just checked another db with a longish blocklist - but most of the images in it were from 2018 or older. So that might be an issue from older KPA versions (?). So ... I guess, we should close this as "not reproducible" - at least for now. I also am quite sure, that I never deleted files from the database only - but who knows, maybe I failed to do a few times (??). Thanks for looking into this. That's good news! I checked my backup archive and my blocklist is also quite old. I will clean it up and watch for new entries. Thank you for the additional testing. Closing as not reproducible. This happened to me again - files appeared in my real album's blocklist a few days ago. Here is one way this can happen: * start the demo, save, and quit. * rm spiff.jpg from the /tmp demo folder. * restart the demo, open the thumbnail view, select spiff.jpg and hit the Delete key. Since the image file is missing, the only option enabled in the delete dialog is "block from database" which adds the file to the block list. So this is as-designed. The delete logic could be smarter and not block a file that doesn't exist, or maybe offer an additional option to simply forget the file in this case? Perhaps kphotoalbum should provide a way for the user to view and edit the block list. Git commit 9e7cdfcd9df125b585d874492db89a0ef6e4a034 by Johannes Zarl-Zierl. Committed on 08/02/2026 at 22:42. Pushed by johanneszarl into branch 'master'. Don't add nonexisting files to blocklist Until now, any files to be removed from the database which were not deleted or moved to trash were added to the block list. In reality, this leads to the blocklist growing larger than needed. The only reason to add files to the block list is when they are existing files in the image directory that should be ignored. If the files are not on disk (usually because they are deleted outside of kphotoalbum), there's no need to prevent them from being re-added. M +10 -2 MainWindow/DeleteDialog.cpp M +1 -1 MainWindow/DuplicateMerger/DuplicateMerger.cpp M +10 -11 Utilities/DeleteFiles.cpp M +12 -1 Utilities/DeleteFiles.h https://invent.kde.org/graphics/kphotoalbum/-/commit/9e7cdfcd9df125b585d874492db89a0ef6e4a034 |