| Summary: | SwipeListItem in RtL has broken padding and prints errors | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | cwo <cwo.kde> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | kde, notmart |
| Priority: | HI | ||
| Version First Reported In: | Master | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | kde connect plugin settings with wrong highlight padding | ||
Oops, forgot: Operating System: Fedora Linux 43 KDE Plasma Version: 6.5.80 KDE Frameworks Version: 6.20.0 Qt Version: 6.10.0 Kernel Version: 6.17.7-300.fc43.x86_64 (64-bit) Graphics Platform: Wayland Processors: 4 × Intel® Core™ i5-6200U CPU @ 2.30GHz Memory: 16 GiB of RAM (15.5 GiB usable) Graphics Processor: Intel® HD Graphics 520 Same thing happens on a different computer using the Fedora builds of everything, instead of my own master builds. |
Created attachment 186755 [details] kde connect plugin settings with wrong highlight padding SUMMARY SwipeListItem prints a lot of errors when used in RtL, and the highlight is misaligned. Tested using both KDE Connect's Plugin Settings page and Discover's Settings, both have the error and misaligned highlight (need to sue keyboard navigation in Discover, it does not highlight on hover). The error is a lot of <Unknown File>: QML QQuickAnchors: Binding loop detected for property "left": file:///home/wolki/kde/usr/lib64/qml/org/kde/kirigami/SwipeListItem.qml:309:17 <Unknown File>: QML QQuickAnchors: Binding loop detected for property "left": file:///home/wolki/kde/usr/lib64/qml/org/kde/kirigami/SwipeListItem.qml:309:17 qml: Don't override the leftPadding or rightPadding on a SwipeListItem! This makes it impossible for me to adjust my layout as I need to for various usecases. I'll try to fix the mistake for you, but you should remove your overrides from your app's code entirely. If I can't fix the paddings, I'll fall back to a default layout, but it'll be slightly incorrect and lacks adaptations needed for touch screens and right-to-left languages, among other things. Looking at the implementations, it seems they don't do anything with the leftPadding or rightPadding values, and the errors do not happen in LtR. I suspect there's something wrong in SwipeListItem that triggers this . STEPS TO REPRODUCE 1. kdeconnect-app --reverse 2. Click an available device in sidebar 3. Click Settings button in toolbar 4. Hover over entry OBSERVED RESULT Errors printed in console output, misaligned highlight on list items EXPECTED RESULT No errors, correct padding SOFTWARE/OS VERSIONS Windows: macOS: (available in the Info Center app, or by running `kinfo` in a terminal window) Linux/KDE Plasma: KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION