| Summary: | Tabbar margins are inconsistent and do not fill to content | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | doncbugs |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | minor | CC: | kde, kdedev |
| Priority: | NOR | ||
| Version First Reported In: | 6.5.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Differences in how tabbar.svg is drawn and the overlap behavior | ||
Thanks for the bug report, and the detailed explanation. I see from the screen shot what you're talking about. I'm able to reproduce this on git-master. In particular, with a panel height of 36: - The outline when clicking on the Application Launcher icon does get more narrow than the icon. - The border around the clock widget is narrow enough to cut off text / numbers - The border around system tray icons, however, looks appropriate (in the screenshot, it's too narrow) Looking at the theme in Get New... the theme author states it works correctly on Plasma 6.4 but "Plasma 6.5.x has broken the API and it may look unusual". This may be a regression. Note that one of the effects the author mentions aren't present on git-master or 6.5.3 - "Background Contrast". (In reply to TraceyC from comment #1) > Looking at the theme in Get New... the theme author states it works > correctly on Plasma 6.4 but "Plasma 6.5.x has broken the API and it may look > unusual". This may be a regression. Note that one of the effects the author > mentions aren't present on git-master or 6.5.3 - "Background Contrast". The note about the API break is tied to the removal of the intensity (brightness) parameter for the blur effect, which caused the themes to stop looking bright. I would not be surprised if the spacing changed from version to version, however. The cramped tabbar for Kickoff was definitely in 6.4 and can be seen in the theme's screenshots. |
Created attachment 186622 [details] Differences in how tabbar.svg is drawn and the overlap behavior SUMMARY Although normally hidden with Breeze's minimal line style for the tabbar.svg, styles that use the full 9 parts of tabbar.svg to enclose foreground elements reveal misalignments and Breeze-specific hacks. In the past (5.x?), I believe it did work properly. STEPS TO REPRODUCE 1. Install a Plasma Style that uses a full style for tabbar.svg, I used Sumac Night Molten Glass 2. Apply the Plasma Style to a default desktop layout with panel and Kickoff menu 3. Open the Kickoff menu (can also see System Tray, Clock, or Show Desktop plasmoids) OBSERVED RESULT The tabbar.svg drawn over the application menu icon has a very slim width, most likely to better suite the Breeze line style. If the panel height is reduced further, it will become slimmer and the tabbar.svg corners will be overlapped, which produces an undesirable appearance. Additionally, the clock and system tray plasmoids can also have unusual or even overlapped sizes. The clock appears to have its width shrunk, but the option to show the date beside the time seems to have the biggest impact. The system tray can still overlap tabbar for tray icons, but the major problem is that the arrow seems to be neglected in the width calculation and the assets get drawn in the middle of the arrow. The show desktop plasmoid also appears to follow the same logic that will overlap two sides. EXPECTED RESULT The tabbar's 8 outer pieces should probably encompass the Kickoff icon and perhaps leverage the margins provided by the theme asset to decide readjustments. Overlapping 2 opposite sides when running out of space is unideal. Either expansion beyond the plasmoid's expected compact form should occur or, perhaps risky, the assets should be shrunk to fit. SOFTWARE/OS VERSIONS Operating System: Fedora Kinoite KDE Plasma Version: 6.5.1 KDE Frameworks Version: 6.19.0 Qt Version: 6.10 ADDITIONAL INFORMATION