| Summary: | Plasma Style Contrast Effect Settings No Longer Honored | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | doncbugs |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | akselmo, kde |
| Priority: | NOR | ||
| Version First Reported In: | 6.5.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Sumac Molten Glass before and after comparison
default blur effect |
||
This is now handled by the `plasmarc` file of your plasma theme: ``` [ContrastEffect] enabled=false contrast=0.2 saturation=10 ``` (In reply to Akseli Lahtinen from comment #1) > This is now handled by the `plasmarc` file of your plasma theme: > > ``` > [ContrastEffect] > enabled=false > contrast=0.2 > saturation=10 > ``` I am not sure this addresses what I reported? Are you saying my syntax is incorrect and that it should actually be working? Created attachment 186515 [details]
default blur effect
Sorry, I misread parts of it.
The contrast effect was merged with the blur effect, as far as I know. But it's handled by the theme itself now, in plasmarc file.
I downloaded `sumac-night-molten-glass-plasma` and this is what it looks like to me after removing the commented out parts in the plasmarc file, with default blur effect settings.
Does this look right to you?
It is a bit tricky to say for sure if that is correct without an apples-to-apples comparison, perhaps with the Plasma 6.4 dark wallpaper it might be easier. The asset in your screenshot looks a little darker than I expect, but that could be an optical illusion. The appearance still looks unchanged when I remove the commented out lines, but are you saying that the commented out lines are causing different behavior on your machine? They should just be comments, but has something changed with the parsing when the new merged effect was created such that # comments are no longer ignored? Unrelated, but why does your screenshot seem to have sliders and maybe tabbars unthemed? (In reply to doncbugs from comment #4) > It is a bit tricky to say for sure if that is correct without an > apples-to-apples comparison, perhaps with the Plasma 6.4 dark wallpaper it > might be easier. The asset in your screenshot looks a little darker than I > expect, but that could be an optical illusion. > > The appearance still looks unchanged when I remove the commented out lines, > but are you saying that the commented out lines are causing different > behavior on your machine? They should just be comments, but has something > changed with the parsing when the new merged effect was created such that # > comments are no longer ignored? Indeed, they should be ignored. I just was wondering if there is any change for you or not if you remove them, thinking maybe the bug is in config handling. Though for me, I didn't have any difference. > Unrelated, but why does your screenshot seem to have sliders and maybe > tabbars unthemed? It's possible I didn't install the theme correctly. In Plasma 6.5.2 it appears to be working again, but has regressed with brightness settings being ignored. |
Created attachment 186442 [details] Sumac Molten Glass before and after comparison SUMMARY In Plasma 6.5.1, Contrast Effect settings supplied by the Plasma Style are no longer honored and arbitrary values are passed. The Contrast Effect setting also appears to have been removed entirely in 6.5.x, as it does not appear in System Settings' Desktop Effects? STEPS TO REPRODUCE 1. Install a Plasma Style theme that passes Contrast Effect parameters, I used Sumac Night Molten Glass 2. Apply the Plasma Style 3. View a plasmoid/dialog, ideally against a colorful background OBSERVED RESULT Dialogs are extremely saturated and Contrast Effect settings in the theme do not appear to be used at all. It seems the Contrast Effect is configured with arbitrary values. Changing the Contrast Effect parameters provided in the plasmarc do not appear to make any change and the windows stay extremely saturated. EXPECTED RESULT Contrast Effect settings passed by the Plasma Style are used when applying the Contrast Effect. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Fedora Linux 43 KDE Plasma Version: 6.5.1 KDE Frameworks Version: 6.19.0 Qt Version: 6.10.0 ADDITIONAL INFORMATION Updates to KDE break plasma themes almost, if not every update. This change simply happens to have very very high visibility. Is there a need for a line of communication between theme developers and plasma developers? Perhaps 3rd party resources should be incorporated into testing pipelines? The ideal implementation in my opinion is to follow the settings of the Plasma Style, but also provide the user with a means of overriding the setting. Some other bug reports suggest that the functionality is going to disappear from plasma.