Bug 511461

I think that I'm going to close all issues for Darwin 16 (MacOS X 10.12) and earlier. The macs that I can access are running
10.7 Intel (but I hardly ever boot that machine, I should take it to be recycled)
10.13 Intel in VirtualBox (this is the last version that we support)
13 Intel
15 arm64 (a new mac mini)

Overall I get about 200 fails on 10.13. Since memcheck is probably what most users want I'll concentrate on that (and 'none' after that).

Here is a list of issues that I see

== 262 tests, 36 stderr failures, 4 stdout failures, 0 stderrB failures, 0 stdoutB failures, 0 post failures ==

Many leaks in libc
==============
Affects at least 8 tests

For instance, the "accounting" test:
--- accounting.stderr.exp       2022-06-06 23:06:24.000000000 +0200
+++ accounting.stderr.out       2025-11-01 07:53:47.000000000 +0100
@@ -5,8 +5,8 @@

 HEAP SUMMARY:
-    in use at exit: 0 bytes in 0 blocks
-  total heap usage: 1 allocs, 1 frees, 1 bytes allocated
+    in use at exit: 17,750 bytes in 151 blocks
+  total heap usage: 173 allocs, 22 frees, 26,199 bytes allocated

autofreepool* also have extra LEAK SUMMARY blocks

some tests have differences in leak categories

Possible fixes:
If the summary is not part of the test, add -q to vgopts
Otherwise a) change the summary to ignore suppressed allocs or b) add expecteds/filters

Aborts in some overlap tests
=======================
Affects 4 tests

I need to look at this a bit more but I think that debug builds use checked str* and mem* that we aren't redirecting.

bug401284 gives

==13887== Process terminating with default action of signal 6 (SIGABRT)
==13887==    at 0x10063BB96: __pthread_sigmask (in /usr/lib/system/libsystem_kernel.dylib)
==13887==    by 0x10031223A: __abort (in /usr/lib/system/libsystem_c.dylib)
==13887==    by 0x1003121BC: abort (in /usr/lib/system/libsystem_c.dylib)
==13887==    by 0x100312320: abort_report_np (in /usr/lib/system/libsystem_c.dylib)
==13887==    by 0x100336BF4: __chk_fail (in /usr/lib/system/libsystem_c.dylib)
==13887==    by 0x100336C04: __chk_fail_overlap (in /usr/lib/system/libsystem_c.dylib)
==13887==    by 0x100336C35: __chk_overlap (in /usr/lib/system/libsystem_c.dylib)
==13887==    by 0x100336D0A: __strncat_chk (in /usr/lib/system/libsystem_c.dylib)
==13887==    by 0x100000F0C: main (bug401284.c:10)

Clearly we aren't redirecting __strncat_chk

libc functionality
==============
Darwin doesn't have aligned_alloc (or is it memalign?)

duplicate_align_size_errors needs a Darwin expected

clang DWARF differences
====================
Probably the biggest category (10 or more?). No inline info, variable names not detected.

scalar and scalar_nocancel
======================
These are Darwin-specific. Need to look at what has changed.

Other
=====
gone_abort_xml extra addr and missing frame
post-syscall fails to interrupt
thread_alloca segfaults

redir failures
==========
static malloc and wrapmallloc and wrapmallocstatic
wcpncpy

Stack description
==============
descr_belowsp has several diffs as to how Darwin sees the memory below the stack.