| Summary: | LTP testcase munmap01 fails under valgrind | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | mcermak |
| Component: | general | Assignee: | mcermak |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mark |
| Priority: | NOR | ||
| Version First Reported In: | 3.25 GIT | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
proposed patch
updated patch |
||
|
Description
mcermak
2025-10-06 08:51:50 UTC
Created attachment 185548 [details]
proposed patch
The filters/munmap01 file needs to be added to auxprogs/Makefile.am (LTP_FILTERS) so it gets included in a make dist. OK with that change. I wonder if we need a --really-quiet-even-for-fatal-crashes option? Normally you would like to see these SEGVs messages. Just not in these contrived testcases. And it seems all our filters are variants on these SEGV messages. Created attachment 185728 [details] updated patch Hi Mark, (In reply to Mark Wielaard from comment #2) > The filters/munmap01 file needs to be added to auxprogs/Makefile.am > (LTP_FILTERS) so it gets included in a make dist. > OK with that change. Attached updated, rebased patch. > I wonder if we need a --really-quiet-even-for-fatal-crashes option? > Normally you would like to see these SEGVs messages. Just not in these > contrived testcases. > And it seems all our filters are variants on these SEGV messages. These filters are rare: Currently we have 4 filters for whole the LTP testsuite. Introducing --really-quiet-even-for-fatal-crashes could paper over real issues. As long as filters are conveniently maintainable, I think adding a filter is fine. Thoughts? (In reply to mcermak from comment #3) > > I wonder if we need a --really-quiet-even-for-fatal-crashes option? > > Normally you would like to see these SEGVs messages. Just not in these > > contrived testcases. > > And it seems all our filters are variants on these SEGV messages. > > These filters are rare: Currently we have 4 filters for whole the LTP > testsuite. > Introducing --really-quiet-even-for-fatal-crashes could paper over real > issues. > As long as filters are conveniently maintainable, I think adding a filter is > fine. > > Thoughts? You are probably right that it is fine for now. Pushed your new filter. If we have to add more in the future we can always some "super-quiet" option. commit ef3f78a3d66db60af42d6b9118deb71bf8c4ba0b Author: Martin Cermak <mcermak@redhat.com> Date: Mon Oct 13 09:53:56 2025 +0200 Silence false positive failure of LTP munmap01 After upgrading LTP testsuite version to 20250930 (tracked in bug 510169) munmap01 syscall test started failing. It however turns out that this testcase was substantially rewritten and the failure is expected. This update will silence mentioned false positive. https://bugs.kde.org/show_bug.cgi?id=510292 |