Summary: | Does not warn when rebooting if other users are logged in | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Derek Enz <derekenz> |
Component: | Session Management | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | kdedev, natalie_clarius, nate |
Priority: | HI | Keywords: | regression |
Version First Reported In: | 6.4.5 | ||
Target Milestone: | 1.0 | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/f4aaf1de58b09778c3aa111fd3bdf3f32ab93659 | Version Fixed In: | 6.4.6 |
Sentry Crash Report: |
Description
Derek Enz
2025-10-01 17:34:15 UTC
Changing to wishlist, since it's a feature request rather than a bug This seems reasonable Actually we do have this: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/lookandfeel/org.kde.breeze/contents/logout/Logout.qml?ref_type=heads#L166 But it's broken. Probably by me, when I removed the "leave" option for Plasma 6.0. I'll fix it. Raising to critical severity since this could cause data loss for another user. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5882 Git commit 5fa05a00a642a36bee70539ba2043d4fbbef76b3 by Nate Graham. Committed on 02/10/2025 at 21:02. Pushed by ngraham into branch 'master'. Logout: don't mistakenly think the model includes ourselves It does not. Thus, we need to check for more than *zero* items in the model to determine if there are any other users logged in. FIXED-IN: 6.5.0 M +3 -3 lookandfeel/org.kde.breeze/contents/logout/Logout.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/5fa05a00a642a36bee70539ba2043d4fbbef76b3 Git commit 5367ad5dd443629a1956cafd444dd370c8be8b1b by Nate Graham. Committed on 02/10/2025 at 21:04. Pushed by ngraham into branch 'master'. Logout: be specific about which sessions to include in the model Better to be specific here rather than leave it up to the default settings, which could change in Plasma 7 or later. M +3 -0 lookandfeel/org.kde.breeze/contents/logout/Logout.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/5367ad5dd443629a1956cafd444dd370c8be8b1b Git commit 2815281d214e41158dea5eb9ff5d6d465ec89588 by Nate Graham. Committed on 02/10/2025 at 22:31. Pushed by ngraham into branch 'Plasma/6.5'. Logout: don't mistakenly think the model includes ourselves It does not. Thus, we need to check for more than *zero* items in the model to determine if there are any other users logged in. FIXED-IN: 6.5.0 (cherry picked from commit 5fa05a00a642a36bee70539ba2043d4fbbef76b3) Co-authored-by: Nate Graham <nate@kde.org> M +3 -3 lookandfeel/org.kde.breeze/contents/logout/Logout.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/2815281d214e41158dea5eb9ff5d6d465ec89588 Git commit f4aaf1de58b09778c3aa111fd3bdf3f32ab93659 by Nate Graham. Committed on 02/10/2025 at 22:32. Pushed by ngraham into branch 'Plasma/6.4'. Logout: don't mistakenly think the model includes ourselves It does not. Thus, we need to check for more than *zero* items in the model to determine if there are any other users logged in. FIXED-IN: 6.5.0 (cherry picked from commit 5fa05a00a642a36bee70539ba2043d4fbbef76b3) Co-authored-by: Nate Graham <nate@kde.org> M +3 -3 lookandfeel/org.kde.breeze/contents/logout/Logout.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/f4aaf1de58b09778c3aa111fd3bdf3f32ab93659 |