Bug 510025

Summary:	MS Money import: split transaction comments lost/overwritten
Product:	[Applications] skrooge	Reporter:	A D <kdebugs5828>
Component:	general	Assignee:	Stephane MANKOWSKI <stephane>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	25.1.0
Target Milestone:	25.1.0
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://invent.kde.org/office/skrooge/-/commit/41c38aec2e27a836d23b51f69d22ad3f727089d5	Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshots showing MS Money transaction, Observed and Expected Skrooge transactions zip containing MS Money file and PNG screenshot

Description A D 2025-09-28 13:27:12 UTC

Created attachment 185341 [details]
Screenshots showing MS Money transaction, Observed and Expected Skrooge transactions

SUMMARY
When importing from a MS Money file, the comments in split transactions ("Description" in the MS Money split dialog) are all overwritten by the comment from the parent transaction. 

STEPS TO REPRODUCE
1. Import MS Money file containing split transaction with different comments in parent transaction and child splits (Top screenshot attached)
2. open imported transaction in Skrooge

OBSERVED RESULT
Comment from parent transaction is written in all splits (middle screenshot attached)

EXPECTED RESULT
Comments in splits should be same as in MS Money (bottom screenshot attached)

SOFTWARE/OS VERSIONS: 
Linux Mint 22.2 (using Ubuntu 24.04 Noble) / Windows 10 + wsl
Skrooge 25.4.0 (from PPA and built from source)

ADDITIONAL INFORMATION
https://invent.kde.org/office/skrooge/-/blob/V25.4.0/plugins/import/skrooge_import_mny/skgimportpluginmny.cpp?ref_type=tags#L449 - 
existing code: ...setComment(operation[... => Observed result
modified: ...setComment(transaction[... => Expected result

Also, at line 460, the comment should probably be something like "Skrooge import repair", instead of '...operation[...("memo")]...'

Comment 1 Stephane MANKOWSKI 2025-09-28 16:09:53 UTC

Could you provide a sample .mny file to reproduce this issue ?

Comment 2 A D 2025-09-28 16:32:09 UTC

Created attachment 185345 [details]
zip containing MS Money file and PNG screenshot

No problem, here it is

The MS Money file contains one account with one transaction containing splits (and an unassigned amount, so that the sum of splits doesn't match the amount of the parent transaction)

The screenshot shows the transaction in MS Money

Comment 3 Stephane MANKOWSKI 2025-09-28 17:09:42 UTC

Git commit 41c38aec2e27a836d23b51f69d22ad3f727089d5 by Stéphane MANKOWSKI.
Committed on 28/09/2025 at 17:09.
Pushed by smankowski into branch 'master'.

Correction bug 510025: MS Money import: split transaction comments lost/overwritten

M  +1    -0    CHANGELOG
M  +1    -1    plugins/import/skrooge_import_mny/skgimportpluginmny.cpp
A  +-    --    tests/input/skgtestimportmny3/510025.mny
M  +22   -0    tests/skgbankmodelertest/skgtestimportmny3.cpp

https://invent.kde.org/office/skrooge/-/commit/41c38aec2e27a836d23b51f69d22ad3f727089d5