| Summary: | Buttons "Restore Defaults" and "Apply" are greyed in Focus pane | ||
|---|---|---|---|
| Product: | [Applications] kstars | Reporter: | Jean-Claude <jcjesior> |
| Component: | general | Assignee: | John Evans <john.e.evans.email> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Other | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | screenshot of the bug | ||
|
Description
Jean-Claude
2025-09-21 13:28:37 UTC
Hi Jean-Claude, This isn't a "bug" per se but a relic of the history of KStars. This is the standard "Options" dialog that KStars uses all over the place that is a KDE dialog. We standardised on this dialog for options on align, guiding etc and so makes sense to use it in Focus for consistency. In fact I did a project to move Focus options from the main screen into this dialog to tidy up Focus and standardise on the same KDE Options dialog as Align, Guiding, etc uses. However, Focus options behave very differently under the hood. They are persisted alongside the Optical Train in the user database. This change was made when Optical Trains came in a few years ago, and for good reason as it allows different Focus settings per OT. So the options approach for Focus is very different from say, Align. One of the differences is that Options in, say Align, are written to the kstarsrc file via KDE code. KDE manages this process and allows the user to perform actions like Apply and Restore because changes are batched until the user hits Apply. Focus options behave very differently and are written in real time as they are changed to the user database bypassing the KDE layer. There is only a concept of current setting. No concept of batching. As the user changes an option that immediately becomes the current setting and is persisted. So the notion of Apply has no meaning; neither does the notion of Restore. I would have liked to remove the Apply and Restore buttons but the KDE framework doesn't allow this - it only allows the buttons to be greyed out. So the choice I had was either to do what I did, or write a new Options dialog for Focus without these buttons but then the UI consistency of Focus with other functions would have been lost. I'm happy to change things but with the constraints I've highlighted above I think the current setup is the best compromise. But always happy to discuss,. Regards, John. Thank you so much John for this extensive reply which made the things clearer. I love so much KStars which is with Siril the softwares I use the most. I wish you a very good year for 2026. Thanks again. Thanks Jean-Claude and Happy New Year to you too! Hopefully lots of clear skies this year! I'll mark this as Resolved but if you think of an improvement let me know and we can re-open it. |