| Summary: | sys_quotactl and sys_quotactl_fd need extra ARG4 check | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | mcermak |
| Component: | general | Assignee: | mcermak |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mark |
| Priority: | NOR | ||
| Version First Reported In: | 3.25 GIT | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
proposed patch
updated patch |
||
|
Description
mcermak
2025-09-18 11:03:50 UTC
Created attachment 185399 [details]
proposed patch
NEWS entry OK. All linux handlers for quotactl and quotactl_fd added a POST handler. - Question, why isn't quotactl wrapped on ppc32? Probably just an oversight, ppc64 was wrapped in commit 7f74ba249 Typo funtion_name -> function_name argument corrected in common_[pre|post]_io_getevents. OK Added common_[pre|post]_quotactl_p4_check called from PRE/POST quotactl[_fd] wrappers. OK - common_pre_quotactl_p4_check should not SET_STATUS_Failure( VKI_EINVAL ) on unknown subop, maybe the kernel does know, if not the kernel will set it (maybe warn? if not quiet?) vki-linux.h added macros to get subcommand, subcommand ids and structs used. OK. Looks good, but would like to see ppc32 wrapped and SET_STATUS_Failure removed from common_pre_quotactl_p4_check. Created attachment 187322 [details] updated patch Thank you for the thorough review, Mark. I'm attaching updated and re-tested patch, hopefully addressing your comments. Build bots running: https://builder.sourceware.org/buildbot/#/changes/104193 (In reply to mcermak from comment #3) > Created attachment 187322 [details] > updated patch > > Thank you for the thorough review, Mark. I'm attaching updated and > re-tested patch, hopefully addressing your comments. Yes, looks good. Please push if the buildbots are happy. Pushed as commit 37d9e2085e0ac28a3fa807670c1055bdadb5f773 |