| Summary: | invent.kde.org Group icons look wrong in GitLab dark mode | ||
|---|---|---|---|
| Product: | [Websites] www.kde.org | Reporter: | Tamás Králl <tamaskrall42> |
| Component: | general | Assignee: | kde-www mailing-list <kde-www> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | minor | CC: | kde, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Other | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
icons look bad in GitLab dark mode
VDG icon with removed white background Plasma Group icon with white outlines for better readability in dark mode |
||
These repo icons are just PNG files. To my knowledge Gitlab doesn't have any support for separate light and dark repo icons, or for re-coloring SVG icons. So I don't believe there's a way to fix this. I could make a PNG version of the VDG icon, so that's simple to fix. The Plasma icon needs some actual changes, perhaps a white outline around the icon, so it looks readable in dark mode. If I do make these icons, where can I upload them? If you want to create new versions of the icons themselves that look equally good against both light and dark backgrounds, you can submit them as merge requests to the git repos they live in. Hi, I've created versions of these icons to look nicer in dark mode. However, I can't find the repositories they live in. The Sysadmin/Git Repository Metadata seems to have something similar for the Plasma icon, but not for the VDG one. Can you please help me find the appropriate location to upload these newly created icons? Wherever you see them on invent.kde.org, that's the git repo where they live. I don't think I can create a merge request for a GitLab "Group" like the Plasma and VDG Groups. Maybe I don't have access to that feature? I guess I'll upload the pictures here. Created attachment 185188 [details]
VDG icon with removed white background
Created attachment 185189 [details]
Plasma Group icon with white outlines for better readability in dark mode
Thanks! I've made the change for the VDG team, but it looks like I don't have access to do it for the Plasma group. You'll need to file a sysadmin ticket to get that done. You can do so at https://phabricator.kde.org/maniphest/task/edit/form/2/ These icons are governed by sysadmin/repo-metadata, group-metadata/ folder. Aha! Thanks. Or perhaps instead of a newly created logo, the one at https://kde.org/stuff/clipart/logo/plasma-logo-colorful-128x128.png could be used for the Plasma Group on Invent. I'll leave this up to the developers. You could submit a merge request to replace https://invent.kde.org/sysadmin/repo-metadata/-/blob/master/group-metadata/plasma/group.png |
Created attachment 184539 [details] icons look bad in GitLab dark mode SUMMARY The Plasma and VDG groups on invent.kde.org have an icon that doesn't look great in GitLab's dark mode. The Plasma group's icon is a PNG that's entirely grey, which has too little contrast with the GitLab dark mode's background color (also dark grey). The VDG icon is a JPG, which has a white background, since JPG doesn't support transparency. STEPS TO REPRODUCE 1. Set system/browser theme to dark 2. Go to invent.kde.org 3. Look for the Plasma and VDG groups OBSERVED RESULT Both groups' icons look bad due to contrast EXPECTED RESULT The icons look normal like other group icons