Bug 508869

Summary:	x86-linux: simplify scalar test output
Product:	[Developer tools] valgrind	Reporter:	Matthias Schwarzott <zzam>
Component:	memcheck	Assignee:	Paul Floyd <pjfloyd>
Status:	RESOLVED FIXED
Severity:	normal	CC:	pjfloyd
Priority:	NOR
Version First Reported In:	3.25 GIT
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	x86-linux: scalar: remove line numbers from output x86-linux: scalar: remove line numbers from output (V2) x86-linux: scalar: remove line numbers from output (V3)

Description Matthias Schwarzott 2025-08-28 18:36:30 UTC

Created attachment 184533 [details]
x86-linux: scalar: remove line numbers from output

Removing the line numbers from x86-linux scalar test output. As the output is structured by the syscall-headers the line numbers are not needed. filter is identical to https://bugs.kde.org/show_bug.cgi?id=508777

Line numbers in this case just make the patches way larger.
see e.g. https://bugs.kde.org/show_bug.cgi?id=508779

Alternatively even the file-name / the complete callstack could be stripped.

Looking at the other scalar outputs suggests that the arm64 scalar test might also want to have the filter.
$ wc -l $(git ls-files "*linux*scalar*.stderr.exp") 
    62 memcheck/tests/amd64-linux/scalar.stderr.exp
  2645 memcheck/tests/arm64-linux/scalar.stderr.exp
   156 memcheck/tests/riscv64-linux/scalar.stderr.exp
  4243 memcheck/tests/x86-linux/scalar.stderr.exp
     6 memcheck/tests/x86-linux/scalar_exit_group.stderr.exp
     3 memcheck/tests/x86-linux/scalar_fork.stderr.exp
    29 memcheck/tests/x86-linux/scalar_openat2.stderr.exp
    12 memcheck/tests/x86-linux/scalar_supp.stderr.exp
     3 memcheck/tests/x86-linux/scalar_vfork.stderr.exp

Comment 1 Matthias Schwarzott 2025-08-28 20:31:44 UTC

Created attachment 184536 [details]
x86-linux: scalar: remove line numbers from output (V2)

Comment 2 Paul Floyd 2025-08-29 08:19:25 UTC

filter_scalar needs to be in Makefile.am dist_noinst_SCRIPTS so that it gets included in the tarballs produced by the dist* make targets.

Comment 3 Matthias Schwarzott 2025-08-29 09:41:49 UTC

Created attachment 184551 [details]
x86-linux: scalar: remove line numbers from output (V3)

Comment 4 Paul Floyd 2025-08-29 10:44:55 UTC

Thanks for the patch. I changed the commit message to include the bugzilla id and added a line to NEWS.

commit 3399c455fa5068dbf1d10f150160ea67fff85477 (HEAD -> master, origin/master, origin/HEAD)
Author: Matthias Schwarzott <zzam@gentoo.org>
Date:   Thu Aug 28 22:30:25 2025 +0200

    Bug 508869 - x86-linux: simplify scalar test output