| Summary: | Attempting to invoke inline `git blame` functionality fails and causes `flatpak-session-helper` to consume excessive CPU resources | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | waqar.17a |
| Priority: | NOR | ||
| Version First Reported In: | Git | ||
| Target Milestone: | --- | ||
| Platform: | Flatpak | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/-/commit/b666ade925629013103be988760896b9795c6482 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2025-08-21 20:37:55 UTC
Git commit 537542367a509055c73670da94feceac6b4add59 by Waqar Ahmed. Committed on 26/08/2025 at 07:32. Pushed by waqar into branch 'master'. Fix infinite loop in git blame It was assuming that the commit hash is always arg[1] which is not true in the case of flatpak where the process is invoked via a helper. So instead, use better logic to find the commit that the process result is for. M +10 -3 addons/git-blame/kategitblameplugin.cpp https://invent.kde.org/utilities/kate/-/commit/537542367a509055c73670da94feceac6b4add59 Thank you Waqar! Git commit b666ade925629013103be988760896b9795c6482 by Waqar Ahmed. Committed on 27/08/2025 at 09:23. Pushed by waqar into branch 'release/25.08'. Fix infinite loop in git blame It was assuming that the commit hash is always arg[1] which is not true in the case of flatpak where the process is invoked via a helper. So instead, use better logic to find the commit that the process result is for. (cherry picked from commit 537542367a509055c73670da94feceac6b4add59) Co-authored-by: Waqar Ahmed <waqar.17a@gmail.com> M +10 -3 addons/git-blame/kategitblameplugin.cpp https://invent.kde.org/utilities/kate/-/commit/b666ade925629013103be988760896b9795c6482 Hmm, I'm not seeing this fixed in last night's nightly build. I still get the same result: no inline popup about the commit details, and flatpak-session-helper consumes CPU until killed. > 1. Install Kate from the nightly Flatpak repo (https://cdn.kde.org/flatpak/kate-nightly/org.kde.kate.flatpakref) I just installed kate from the url you gave: > flatpak install --user https://cdn.kde.org/flatpak/kate-nightly/org.kde.kate.flatpakref and it seems to work here. You're right! I had a locally-built Kate that was masking the system-installed nightly version. I can confirm the issue is fixed now. Thanks so much! |