Bug 50832

Subject: Re:  New: bookmark groups of pages

Em S

Subject: [PATCH] Implementation of wishlist/bug 50832

Hi,

{ Relevant bug: http://bugs.kde.org/show_bug.cgi?id=50832 . I am CC'ing 
kde-core since this involves a change to kdelibs. }

This is my suggested implementation for opening a folder of bookmarks. I have 
been using this for a few weeks and it works fine. I only cleaned up the code 
today, so I didn't post before - Let's just hope i didn't introduce any bugs.

I await comments.
BTW, I don't have a CVS account (yet ?). So, if you think this is good, then 
you will have to apply it.

HTH,


Created an attachment (id=645)
bookmarkgroup.patch

Created an attachment (id=646)
konqueror.patch

Luis, I looked at your patches, but I did not try them out yet. 
 
From a syntactic pov I noticed that you used dynamic_cast. This will break with 
gcc 3 under certain circumstances when libraries are involved (and KDE is 
nothing but libraries). You should use the virtual_hook instead to discriminate 
a KBookmarkOwner against a KBookmarkOwnerGroupCapable object like this: 
 
in KBookmarkOwner: 
protected: 
enum VirtualHookId { ClassType }; 
enum ClassId { Id = 0xb9d212ee }; 
 
void KBookmarkOwner::virtual_hook(int id,void *data) { 
  switch (id) { 
    case ClassType: *static_cast<ClassId *>(data) = Id; return; 
  } 
} 
 
in KBookmarkOwnerGroupCapable: 
protected: 
enum ClassId { Id = 0xae07ab2a }; 
 
void KBookmarkOwnerGroupCapable::virtual_hook(int id,void *data) { 
  switch (id) { 
    case ClassType: *static_cast<ClassId *>(data) = Id; return; 
  } 
  KBookmarkOwner::virtual_hook(id,data); 
} 
 
and use instead of 
KBookmarkOwnerGroupCapable* owner = dynamic_cast<KBookmarkOwnerGroupCapable*>( 
m_pOwner ); 
 
something like: 
int clsid; 
m_pOwner->virtual_hook(KBookmarkOwner::ClassType,&clsid); 
KBookmarkOwnerGroupCapable *owner = clsid == KBookmarkOwnerGroupCapable::Id ? 
	static_cast<KBookmarkOwnerGroupCapable*>( m_pOwner ) : 0; 
 
 

Subject: Re:  bookmark groups of pages

{ 
	CC'ing kde-core-devel. Relevant bug and patches at  

http://bugs.kde.org/show_bug.cgi?id=50832 

}

Em Ter

just fyi it is now (for several weeks in fact) possible  
to "open all tabs" in kde cvs, however, the bookmarking 
of the tab set is not yet done. i'll work on this soon. 
 
Alex 

*** Bug 59339 has been marked as a duplicate of this bug. ***

hi, 
 
at last got around to writing this patch,  
i'll be commiting the feature on monday 
for the moment it simply adds a new menu 
item "Bookmark tabs as folder..." 
 
Alex 

Hi! 
 
Many people whant at the LinuxDay a option like that (saving a group of tabs as 
bookmark). I think it was a not so good idear with that folder open things. It was a good 
thing to implement it, too. But many miss to make one bookmark (one bookmarkentry) 
to open a list of tabs. Thay whant the look like it was in mozilla at the moment. I think 
we only must make the url thing in the xml mor flexable, so we can save more than one 
url in a bookmark. 
I hope we can do something like that, too. Many people whant it so!   ;) 
 
Can we reopen this wish? 
 
 
Sven 
 

Subject: Re:  bookmark groups of pages

On Wed, Jul 16, 2003 at 10:57:12PM -0000, S Leiber wrote:
> Many people whant at the LinuxDay a option like that (saving a group of tabs as 
> bookmark). I think it was a not so good idear with that folder open things. It was a good 
> thing to implement it, too. But many miss to make one bookmark (one bookmarkentry) 
> to open a list of tabs. Thay whant the look like it was in mozilla at the moment. I think 
> we only must make the url thing in the xml mor flexable, so we can save more than one 
> url in a bookmark. 
> I hope we can do something like that, too. Many people whant it so!   ;) 
>  
> Can we reopen this wish? 

get votes on the bug and i'll reopen. 

i think its stupid personally. unless 
someone can think of a way of not making 
it confusing as heck for the user then no 
matter how many votes i'll not implement anyway. 

anyways, i'd prefer to learn lessons from 
browsers that people actually use, e.g, opera.
   
sorry but i dislike feature bloat intensely,
Alex