| Summary: | Filelight crash when using smb or sftp | ||
|---|---|---|---|
| Product: | [Applications] filelight | Reporter: | Hirad <redstar> |
| Component: | general | Assignee: | Unassigned bugs <unassigned-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | martin.sandsmark, sitter |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | 25.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/filelight/-/commit/61e4afbb76c491240a9bc1042dc337d5d8c490bf | Version Fixed In: | |
| Sentry Crash Report: | https://crash-reports.kde.org/organizations/kde/issues/226207/events/ebe81859cb27498a9a0474937170e16a/ | ||
| Attachments: | New crash information added by DrKonqi | ||
|
Description
Hirad
2025-07-30 05:43:13 UTC
Created attachment 183650 [details]
New crash information added by DrKonqi
DrKonqi auto-attaching complete backtrace.
Cannot reproduce with git builds. What does the specific URL look like? There was some crashing with redirection urls recently. (In reply to Harald Sitter from comment #2) > Cannot reproduce with git builds. What does the specific URL look like? > There was some crashing with redirection urls recently. For example if I open filelight from dolphin "Disk usage statistics - current folder" on smb://192.168.0.2/Music/, it shows me all the folders and their sizes just fine. But as soon as I click on any of those folders, let's say Abbath or Behemoth or anything, it crash. I've tried to open filelight on different directories, on same 192.168.0.2 or sftp on a server. they all behave the same way. I can reproduce it with frameworks 6.16 but not git, so I guess it's already fixed for 6.17 \o/ Should be out in a week or two. Actually I lied. I can now also reproduce it on a git build. Git commit 15c8385da937047b516fd51eb07bec8d9d76ad9e by Harald Sitter. Committed on 01/08/2025 at 10:51. Pushed by sitter into branch 'master'. memory: prefer shared_ptr for qobject + deleteLater on them introduce a new make_shared_qobject helper that creates a shared_ptr with deleteLater semantics. this notably improves safety when used as class members (that may be used in slot invocations) to prevent use-after-free scenarios. unique_ptr has the disadvantage that its deleter signature matters to the type. it results in very noisy code and complicates assignment of nullptr_ts. shared_ptr meanwhile does not care. as such it seems preferrable. this fixes a crash where we deleted the RemoteLister through resetting it to nullptr in the updateRunning lambda. this would then delete the kdirlister and its internals, leaving the signal call chain in an inconsistent state and crashing when returning the call chain to KCoreDirListerPrivate::CachedItemsJob::done (which was then working with an already deleted this) A +22 -0 src/memory.h [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] M +2 -1 src/radialMap/map.cpp M +1 -1 src/radialMap/map.h M +4 -3 src/scan.cpp M +3 -3 src/scan.h https://invent.kde.org/utilities/filelight/-/commit/15c8385da937047b516fd51eb07bec8d9d76ad9e Git commit 61e4afbb76c491240a9bc1042dc337d5d8c490bf by Harald Sitter. Committed on 01/08/2025 at 10:52. Pushed by sitter into branch 'release/25.08'. memory: prefer shared_ptr for qobject + deleteLater on them introduce a new make_shared_qobject helper that creates a shared_ptr with deleteLater semantics. this notably improves safety when used as class members (that may be used in slot invocations) to prevent use-after-free scenarios. unique_ptr has the disadvantage that its deleter signature matters to the type. it results in very noisy code and complicates assignment of nullptr_ts. shared_ptr meanwhile does not care. as such it seems preferrable. this fixes a crash where we deleted the RemoteLister through resetting it to nullptr in the updateRunning lambda. this would then delete the kdirlister and its internals, leaving the signal call chain in an inconsistent state and crashing when returning the call chain to KCoreDirListerPrivate::CachedItemsJob::done (which was then working with an already deleted this) (cherry picked from commit 15c8385da937047b516fd51eb07bec8d9d76ad9e) Co-authored-by: Harald Sitter <sitter@kde.org> A +22 -0 src/memory.h [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] M +2 -1 src/radialMap/map.cpp M +1 -1 src/radialMap/map.h M +4 -3 src/scan.cpp M +3 -3 src/scan.h https://invent.kde.org/utilities/filelight/-/commit/61e4afbb76c491240a9bc1042dc337d5d8c490bf |