| Summary: | Notification about updates disappears after I close Discover's window | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Piotr Mierzwinski <piotr.mierzwinski> |
| Component: | Notifier | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | ASSIGNED --- | ||
| Severity: | minor | CC: | aleixpol, forestix, nate, piotr.mierzwinski, sitter |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | 6.4.80 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Piotr Mierzwinski
2025-07-19 22:05:41 UTC
[UPDATE] Notifier icon (like cloud) appeared after around 1h. Maybe we should restore the status notifier after discover closes. Shouldn't RefreshNotifierDBus::notify do that? I can't really see how it's supposed to work. Oh indeed. The way it works is that RefreshNotifierDBus issues a broadcast and then DiscoverNotifier runs recheckSystemUpdateNeeded(). The trouble possibly is that recheckSystemUpdateNeeded doesn't actually check notifications? Something like this is probably needed in DiscoverNotifier.cpp
QDBusConnection::sessionBus().connect(QString(),
RefreshNotifierDBus::path,
RefreshNotifierDBus::interface,
RefreshNotifierDBus::notifyNotifier,
this,
SLOT(showUpdatesNotification()));
Discover alerts the user to updates using two distinct mechanisms: Notifications, and Status Icons. Since you mentioned the systray, I think you're talking about this status icon, right? It looks like this: https://raw.githubusercontent.com/KDE/breeze-icons/95b04bb64f3b/icons/status/22/update-low.svg I want to be clear about this distinction because people sometimes confuse the two mechanisms, or are unaware that they are two separate things with two separate purposes, so it's hard to discuss the subject without first making sure that everyone in the conversation understands this. Here's how they differ: Notification: - Represents an event (edge-triggered in signal processing terms) - Intrusive; wants immediate attention; interrupts the user (like an alarm) - Static; shows something that happened in the past (like a log entry) - Dismissed after reading (no longer available after that) - May automatically vanish or be hidden after a timeout Status Icon: - Represents a state (level-triggered in signal processing terms) - Quiet; lets the user look for it when convenient (like a wall clock) - Dynamic; shows whatever is happening right now (like temperature or progress) - Persistent (always available; visible whenever relevant, without clicking or tapping) - Sometimes serves as the only user interface for a tool or application Even developers sometimes make the mistake of conflating these two concepts, and I think that is what has caused the bug described here. (See my next comment.) Assuming this report is about the status icon (not the notification) the bug was introduced here: https://invent.kde.org/plasma/discover/-/merge_requests/886 "notifier: Only show the tray notifier on next notification time" The author was apparently trying to address this issue: https://bugs.kde.org/show_bug.cgi?id=466693 Unfortunately, they misunderstood the differences between a status icon and a notification. (They may have misunderstood the original complaint as well.) They tried to resolve the bug by making the status icon behave like a notification. Of course, this broke the status icon, which some of us actually use and depend upon. That MR was a mistake. I can submit a new MR that will fix it. It's possible that some users might be annoyed by the status icon persistently showing the update status (which is its job). If such people exist, the correct solution for them would be to disable the status icon, and rely on the notifications to alert them to new updates. Please feel free to, thanks! A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/1155 |
