| Summary: | Show (Git) Diff: Poor readability compared to editor | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | madness742 |
| Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | waqar.17a |
| Priority: | NOR | ||
| Version First Reported In: | 25.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/-/commit/693c88e51285b5663de3c06461d4452fa03d200f | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Showcase of the editor, using Breeze Dark.
Showcase of git diff, using Breeze Dark. Showcase of git diff, using Breeze Light. Breeze_dark_diff_view_not_reproduced |
||
Created attachment 183159 [details]
Showcase of git diff, using Breeze Dark.
Created attachment 183160 [details]
Showcase of git diff, using Breeze Light.
Can't reproduce Created attachment 183181 [details]
Breeze_dark_diff_view_not_reproduced
- Explicitly selected Breeze Dark theme in the settings dialog.
- Breeze Light theme is set in System settings.
Breeze dark issue seems to be that you changed the color theme while the "diff" was open. It doesn't react to that. Reopening the diff would work better I guess. Can fix that. Breeze light does have a readability issue it seems. A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1811 Git commit 4c5df53a65eb1de837e4364d7097a2889b1bb625 by Waqar Ahmed. Committed on 12/07/2025 at 10:48. Pushed by waqar into branch 'master'. Rehighlight diff when editor theme changes M +11 -0 apps/lib/diff/diffwidget.cpp M +2 -2 apps/lib/diff/diffwidget.h https://invent.kde.org/utilities/kate/-/commit/4c5df53a65eb1de837e4364d7097a2889b1bb625 Git commit 5b1dab7918fe887281d1fd8358ef45b6081dfe74 by Waqar Ahmed. Committed on 12/07/2025 at 11:08. Pushed by waqar into branch 'master'. Use darkRed/darkGreen in light mode It has better contrast M +2 -2 apps/lib/diff/diffeditor.cpp M +2 -2 apps/lib/diff/difflinenumarea.cpp https://invent.kde.org/utilities/kate/-/commit/5b1dab7918fe887281d1fd8358ef45b6081dfe74 Git commit 5a269d6d5d0b6596989c170b1f9f7bfdf48c8126 by Christoph Cullmann. Committed on 13/07/2025 at 17:22. Pushed by cullmann into branch 'release/25.08'. Rehighlight diff when editor theme changes (cherry picked from commit 4c5df53a65eb1de837e4364d7097a2889b1bb625) Co-authored-by: Waqar Ahmed <waqar.17a@gmail.com> M +11 -0 apps/lib/diff/diffwidget.cpp M +2 -2 apps/lib/diff/diffwidget.h https://invent.kde.org/utilities/kate/-/commit/5a269d6d5d0b6596989c170b1f9f7bfdf48c8126 Git commit 693c88e51285b5663de3c06461d4452fa03d200f by Christoph Cullmann. Committed on 13/07/2025 at 17:23. Pushed by cullmann into branch 'release/25.08'. Use darkRed/darkGreen in light mode It has better contrast (cherry picked from commit 5b1dab7918fe887281d1fd8358ef45b6081dfe74) Co-authored-by: Waqar Ahmed <waqar.17a@gmail.com> M +2 -2 apps/lib/diff/diffeditor.cpp M +2 -2 apps/lib/diff/difflinenumarea.cpp https://invent.kde.org/utilities/kate/-/commit/693c88e51285b5663de3c06461d4452fa03d200f |
Created attachment 183158 [details] Showcase of the editor, using Breeze Dark. SUMMARY The 'Show (Git) Diff' feature has very poor readability compared to the editor. Which makes reading code near impossible with certain built-in themes. STEPS TO REPRODUCE 1. Configure Kate Color theme to "Breeze Dark" to make the issue more noticeable. 2. Open any Git project as a folder. 3. Right click on a file -> Show Git History. 4. Click on any Git History to show the Diff. OBSERVED RESULT In Light Mode (Breeze Light), the coloured line numbers are hard to read. In Dark Mode (Breeze Dark), half the text becomes near impossible to read. EXPECTED RESULT There should be more contrast to improve the readability. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Fedora 42 KDE Plasma Version: 6.4.2 KDE Frameworks Version: 6.15.0 Qt Version: 6.9.1