| Summary: | Global menu widget doesn't work in single-button mode on X11 | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Kishore Gopalakrishnan <kishore96> |
| Component: | Global Menu widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | 0ay, guido.iodice, johnmaverick74, kde, kdedev, mvourlakos, nate, niccolo.venerandi, postix |
| Priority: | HI | Keywords: | regression |
| Version First Reported In: | 6.4.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/d20b171a86b4e57ba18af738ca99d1e620d2c7f4 | Version Fixed/Implemented In: | 6.4.2 for Wayland users; 6.4.4 for X11 users |
| Sentry Crash Report: | |||
|
Description
Kishore Gopalakrishnan
2025-06-25 16:15:56 UTC
*** Bug 506172 has been marked as a duplicate of this bug. *** Can confirm. This regressed in https://invent.kde.org/plasma/plasma-workspace/-/commit/d402f0cb307218971d322bcd54ec998f32f75b62. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5630 Git commit 67374f9e659cfd17c0cb4d7eba0a92a08a72c2d9 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 30/06/2025 at 11:21. Pushed by niccolove into branch 'master'. Do not create multiple QMenu when global menu is set to compact The multiple menus are only required when the global menu is in its full size; when in compact view, only one is needed. M +21 -12 applets/appmenu/lib/appmenuapplet.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/67374f9e659cfd17c0cb4d7eba0a92a08a72c2d9 Git commit 0ce9b2204da994078a739fc8e6bfffd2a9c828fa by Niccolò Venerandi. Committed on 30/06/2025 at 11:55. Pushed by niccolove into branch 'Plasma/6.4'. Do not create multiple QMenu when global menu is set to compact The multiple menus are only required when the global menu is in its full size; when in compact view, only one is needed. (cherry picked from commit 67374f9e659cfd17c0cb4d7eba0a92a08a72c2d9) Co-authored-by: Niccolò Venerandi <niccolo@venerandi.com> M +21 -12 applets/appmenu/lib/appmenuapplet.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/0ce9b2204da994078a739fc8e6bfffd2a9c828fa Updated to: Name : plasma-desktop Version : 6.4.2-1 On Arch Linux, and bug still persists. Just wanted to report it. Maybe it will not be until next release (6.4.2-2 or something not really sure). The bug has not been resolved yet though on my system. Just wanted to report it here in case anyone else is still having this issue. I couldn't figure out how to edit my comment, so making a new one. Apparently, this bug is fixed for wayland users, just not x11 users. Will it not be fixed for x11 too? Should I remove this applet since I use x11? Or is there still a fix in the works for x11 users? Okay, thanks for any insight. (In reply to 8py from comment #8) > I couldn't figure out how to edit my comment, so making a new one. > Apparently, this bug is fixed for wayland users, just not x11 users. Will it > not be fixed for x11 too? Should I remove this applet since I use x11? Or is > there still a fix in the works for x11 users? Okay, thanks for any insight. I don't see anything to indicate this is fixed for Wayland but not X11. The fix was tagged for 6.4.2, but since you're still experiencing this bug, I'll reopen the report. (In reply to TraceyC from comment #9) > (In reply to 8py from comment #8) > > I couldn't figure out how to edit my comment, so making a new one. > > Apparently, this bug is fixed for wayland users, just not x11 users. Will it > > not be fixed for x11 too? Should I remove this applet since I use x11? Or is > > there still a fix in the works for x11 users? Okay, thanks for any insight. > > I don't see anything to indicate this is fixed for Wayland but not X11. The > fix was tagged for 6.4.2, but since you're still experiencing this bug, I'll > reopen the report. I confirm the bug persists in X11 session. (In reply to TraceyC from comment #9) > (In reply to 8py from comment #8) > > I couldn't figure out how to edit my comment, so making a new one. > > Apparently, this bug is fixed for wayland users, just not x11 users. Will it > > not be fixed for x11 too? Should I remove this applet since I use x11? Or is > > there still a fix in the works for x11 users? Okay, thanks for any insight. > > I don't see anything to indicate this is fixed for Wayland but not X11. + if (KWindowSystem::isPlatformWayland() && view() == CompactView) { + m_currentMenu->popup(pos); + connect(actionMenu, &QMenu::aboutToHide, this, &AppMenuApplet::onMenuAboutToHide, Qt::UniqueConnection); + } A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5692 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5692 (In reply to Bug Janitor Service from comment #13) > A possibly relevant merge request was started @ > https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5692 It is quite irritating that when a bug is fixed, a useless check is inserted that only makes the fix work on Wayland. I hope such a thing will never happen again. Git commit 6d56ae9d703cbe1fc6ef2f66cff312ad54c5ae3e by Nate Graham, on behalf of Kishore Gopalakrishnan. Committed on 21/07/2025 at 15:05. Pushed by ngraham into branch 'master'. global menu applet: fix single button mode on X11 The check for Wayland is not needed, since the code inside the block also works on X11 (tested by applying on top of Plasma 6.4.2). Test plan: 1. open Konsole 2. Check that 'File > New Window' works correctly when invoked from the global menu applet in single button mode. (on X11) M +1 -3 applets/appmenu/lib/appmenuapplet.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/6d56ae9d703cbe1fc6ef2f66cff312ad54c5ae3e Git commit d20b171a86b4e57ba18af738ca99d1e620d2c7f4 by Nate Graham. Committed on 21/07/2025 at 17:48. Pushed by ngraham into branch 'Plasma/6.4'. global menu applet: fix single button mode on X11 The check for Wayland is not needed, since the code inside the block also works on X11 (tested by applying on top of Plasma 6.4.2). Test plan: 1. open Konsole 2. Check that 'File > New Window' works correctly when invoked from the global menu applet in single button mode. (on X11) (cherry picked from commit 6d56ae9d703cbe1fc6ef2f66cff312ad54c5ae3e) Co-authored-by: Kishore Gopalakrishnan <kishore96@gmail.com> M +1 -3 applets/appmenu/lib/appmenuapplet.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/d20b171a86b4e57ba18af738ca99d1e620d2c7f4 Okay, bug is fixed. Relevant info (system: Arch Linux), packages: Name : plasma-x11-session Version : 6.4.4-1 Name : kwin-x11 Version : 6.4.4-1 Name : plasma-desktop Version : 6.4.4-1 Thanks for the great work everybody. :) Thanks for confirming! |