| Summary: | Specific .pkpass files can't be imported, empty menu item | ||
|---|---|---|---|
| Product: | [Applications] KDE Itinerary | Reporter: | Illia <illialoo99> |
| Component: | general | Assignee: | Volker Krause <vkrause> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/pim/kitinerary/-/commit/acae9b73667d87072196a3ae6ebb90b34fa3ae57 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Emtpy ticket name
empty menu item |
||
Created attachment 182466 [details]
empty menu item
That indeed would need the specific pkpass to investigate this, sharing by email (vkrause@kde.org) is perfectly fine. Thank you! Just sent it! Git commit 5062b49412c3d09663c63a95bb1c234d8162dcbd by Volker Krause. Committed on 21/06/2025 at 07:56. Pushed by vkrause into branch 'master'. Add fallback for empty pkpass description in that pass list view M +1 -1 src/app/PassDelegate.qml https://invent.kde.org/pim/itinerary/-/commit/5062b49412c3d09663c63a95bb1c234d8162dcbd Git commit 2010fd98692173da074a28741b88ed41a8a7fabb by Volker Krause. Committed on 21/06/2025 at 08:06. Pushed by vkrause into branch 'master'. Work around pkpass type identifier case-sensitivity getting lost in URLs We have paths that pass this through a QUrl::host, which converts to lower-case, and are then unable to find the correct pkpass file on disk again. This shouldn't happen in the first place, but since it's part of the stored schema.org data we have to have a fallback either way to recover already existing data affected by this. M +32 -13 src/app/pkpassmanager.cpp https://invent.kde.org/pim/itinerary/-/commit/2010fd98692173da074a28741b88ed41a8a7fabb Git commit 4fc26cc3180e2b521c1c63b6327e230d128f2334 by Volker Krause. Committed on 21/06/2025 at 07:55. Pushed by vkrause into branch 'master'. Add a few fallbacks for empty pkpass descriptions when importing M +6 -0 src/app/importcontroller.cpp https://invent.kde.org/pim/itinerary/-/commit/4fc26cc3180e2b521c1c63b6327e230d128f2334 Git commit b00600b6ffb4b5ba05cda0dd9575803ad4a943c3 by Volker Krause. Committed on 21/06/2025 at 08:46. Pushed by vkrause into branch 'master'. Add extractor script for ticket-ua railway passes M +2 -0 src/lib/scripts/extractors.qrc A +36 -0 src/lib/scripts/tickets-ua.js A +13 -0 src/lib/scripts/tickets-ua.json https://invent.kde.org/pim/kitinerary/-/commit/b00600b6ffb4b5ba05cda0dd9575803ad4a943c3 Git commit acae9b73667d87072196a3ae6ebb90b34fa3ae57 by Volker Krause. Committed on 21/06/2025 at 09:07. Pushed by vkrause into branch 'release/25.04'. Add extractor script for ticket-ua railway passes (cherry picked from commit b00600b6ffb4b5ba05cda0dd9575803ad4a943c3) M +2 -0 src/lib/scripts/extractors.qrc A +36 -0 src/lib/scripts/tickets-ua.js A +13 -0 src/lib/scripts/tickets-ua.json https://invent.kde.org/pim/kitinerary/-/commit/acae9b73667d87072196a3ae6ebb90b34fa3ae57 Git commit dae94ee1fb0fffe8b88c5d99aa05bbb1ad68b41c by Volker Krause. Committed on 21/06/2025 at 09:17. Pushed by vkrause into branch 'release/25.04'. Add a few fallbacks for empty pkpass descriptions when importing (cherry picked from commit 4fc26cc3180e2b521c1c63b6327e230d128f2334) M +6 -0 src/app/importcontroller.cpp https://invent.kde.org/pim/itinerary/-/commit/dae94ee1fb0fffe8b88c5d99aa05bbb1ad68b41c Git commit 314c2550b90d0c5d0a7a155eea02cd2517913be3 by Volker Krause. Committed on 21/06/2025 at 09:17. Pushed by vkrause into branch 'release/25.04'. Work around pkpass type identifier case-sensitivity getting lost in URLs We have paths that pass this through a QUrl::host, which converts to lower-case, and are then unable to find the correct pkpass file on disk again. This shouldn't happen in the first place, but since it's part of the stored schema.org data we have to have a fallback either way to recover already existing data affected by this. (cherry picked from commit 2010fd98692173da074a28741b88ed41a8a7fabb) M +32 -13 src/app/pkpassmanager.cpp https://invent.kde.org/pim/itinerary/-/commit/314c2550b90d0c5d0a7a155eea02cd2517913be3 Git commit 9b5f4b5e031808cb2b405ac7fbd16c10005d54b7 by Volker Krause. Committed on 21/06/2025 at 09:17. Pushed by vkrause into branch 'release/25.04'. Add fallback for empty pkpass description in that pass list view (cherry picked from commit 5062b49412c3d09663c63a95bb1c234d8162dcbd) M +1 -1 src/app/PassDelegate.qml https://invent.kde.org/pim/itinerary/-/commit/9b5f4b5e031808cb2b405ac7fbd16c10005d54b7 I can confirm, that with the latest commit everything works as intended. Thanks! |
Created attachment 182465 [details] Emtpy ticket name I just tested it on multiple platforms, .pkpass files with Cyrillic characters cannot be imported correctly at all and remain empty in menu. As an example, I can send a .pkpass file that cannot be imported, but it contains sensetive information, so it can only be sent via email. Such files are created by tickets.ua and for other applications that can read .pkpass files, they are valid. Screenshots of how it looks on Android, version 25.04.2 (be5fd3f), are attached.