| Summary: | When scrolling down Folder View widget, clicking on items activates the wrong ones | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Alberto Mattea <alberto> |
| Component: | Desktop icons & Folder View widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | akselmo, cwo.kde, fernandommuniz, hein, kdedev, KMonsefi, nate |
| Priority: | VHI | Keywords: | regression |
| Version First Reported In: | 6.4.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=497498 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/f6c6e03a5fed3435ea47605e232af57140625440 | Version Fixed In: | 6.4.1 |
| Sentry Crash Report: | |||
|
Description
Alberto Mattea
2025-06-18 00:10:01 UTC
Can confirm in both icon view and list view. I bisected plasma-desktop and found that it was caused by this commit: commit 53d67b9a0b82fff40b2057f1ceb74b529b943df5 (HEAD) Author: Christoph Wolk <cwo.kde@posteo.net> Date: Mon May 26 12:17:04 2025 +0200 containments/desktop: redetermine item on click In case of touch events, Folder View already resets the hovered item to the actual click position, as touch does not cause hover events. There is another case where a click on a non-hovered element can happen, namely if the containsMouse determination is blocked by an open context menu. If the user does not move the pointer after opening a context menu, moving the pointer to another item, and closing the context menu, left-clicking will leave the icon completely unaffected and right- clicking will re-open the previous context menu, rather than open the one for the clicked entry. Instead, always take the delegate that was clicked to activate or open the context menu, whether on touch or not. This matches the behavior in Dolphin, where in the same situation the hover feedback is not updated, but clicking still works normally. BUG: 504765 containments/desktop/package/contents/ui/FolderView.qml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) Christoph, could I ask you to take a look at this? A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/3075 Git commit dbd2551e3097433b838facf4045c67427069a581 by Christoph Wolk. Committed on 20/06/2025 at 16:25. Pushed by cwo into branch 'master'. containments/desktop: fix folder view clicking 53d67b9a0b82fff40b2057f1ceb74b529b943df5 made clicking use the same logic to determine the selected item for mouse and touch, rather than relying on hover events. It seems the logic for touch was broken in some cirumstances, namely scrolled views and certain alignments, where the coordinate systems do not align. A similar issue was already fixed elsewhere in folder view with 509b655ef2edef04a13d9afaab6349911beaaeb1, so we reuse the approach here. Related: bug 497498, bug 504569 FIXED-IN: 6.4.1 ---- Would be good if someone could test if this works with touch, as I don't have a functional touch device handy. Might be that this was also broken there (couldn't find a bug report there though) or doesn't apply. M +2 -1 containments/desktop/package/contents/ui/FolderView.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/dbd2551e3097433b838facf4045c67427069a581 Git commit f6c6e03a5fed3435ea47605e232af57140625440 by Christoph Wolk. Committed on 20/06/2025 at 16:25. Pushed by cwo into branch 'Plasma/6.4'. containments/desktop: fix folder view clicking 53d67b9a0b82fff40b2057f1ceb74b529b943df5 made clicking use the same logic to determine the selected item for mouse and touch, rather than relying on hover events. It seems the logic for touch was broken in some cirumstances, namely scrolled views and certain alignments, where the coordinate systems do not align. A similar issue was already fixed elsewhere in folder view with 509b655ef2edef04a13d9afaab6349911beaaeb1, so we reuse the approach here. Related: bug 497498, bug 504569 FIXED-IN: 6.4.1 ---- Would be good if someone could test if this works with touch, as I don't have a functional touch device handy. Might be that this was also broken there (couldn't find a bug report there though) or doesn't apply. (cherry picked from commit dbd2551e3097433b838facf4045c67427069a581) 4445acf7 containments/desktop: fix folder view clicking Co-authored-by: Christoph Wolk <cwo.kde@posteo.net> M +2 -1 containments/desktop/package/contents/ui/FolderView.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/f6c6e03a5fed3435ea47605e232af57140625440 (In reply to cwo from comment #6) > > Would be good if someone could test if this works with touch, as I don't > have a functional touch device handy. Might be that this was also broken > there (couldn't find a bug report there though) or doesn't apply. I tested this on a touchscreen laptop, and verified this bug cannot be reproduced, and the Folder View works as expected. *** Bug 505933 has been marked as a duplicate of this bug. *** *** Bug 506180 has been marked as a duplicate of this bug. *** |