Bug 505636

Summary: Timer Presets just don't work
Product: [Applications] KClock Reporter: Gladox114 <glados9999>
Component: GeneralAssignee: Devin Lin <espidev>
Status: RESOLVED FIXED    
Severity: normal CC: hanyoung
Priority: NOR    
Version First Reported In: 25.04.2   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Gladox114 2025-06-15 17:38:46 UTC
SUMMARY
Wanting to create presets with small, medium and large breaks for Pomodoro techniques, I fail to actually use them. When I save it and click on another Preset, it just creates a Timer with the current settings and ignoring that I was pressing on preset. Its like all Buttons are mapped to "Done" instead.

STEPS TO REPRODUCE
1. Press on "New Timer" in Timers.
2. Create Timer Presets. (Time: 15 Minutes, Label: Break small)
3. Change current minutes/hours/seconds and the Label to something unidentical to your Preset. (Time: 55 Minutes, Label: HELLOWORLD)
4. Press on a Preset (Break Small)

OBSERVED RESULT
See how the changed minutes and labels are used instead of the preset. (Time: 55 Minutes, Label: HELLOWORLD)

EXPECTED RESULT
It should create the timer that you pressed on. (Time: 15 Minutes, Label: Break small)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux 6.14.9-zen1-1-zen (64-bit)
KDE Plasma Version: 6.3.5
KDE Frameworks Version: 6.14.0
Qt Version: 6.9.1

ADDITIONAL INFORMATION
Graphics Platform: Wayland
Comment 1 Devin Lin 2025-06-26 02:44:39 UTC
This is actually fixed in master, but it only releases in August (25.08): https://invent.kde.org/utilities/kclock/-/merge_requests/165

I'll make a fix that will come sooner for 25.04.3
Comment 2 Bug Janitor Service 2025-06-26 02:51:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/kclock/-/merge_requests/211
Comment 3 Devin Lin 2025-06-26 13:41:20 UTC
Git commit 033e713e86d0f91c1f89c1f69241bd169787c9bc by Devin Lin.
Committed on 26/06/2025 at 02:50.
Pushed by devinlin into branch 'release/25.04'.

timers: Fix preset creation and usage (25.04)

This fix is already in master, this is just for 25.04.x

Timers from the preset model were created with the values of the form.
Fix this to actually create timers from the stored presets.

M  +18   -10   src/kclock/qml/timer/TimerForm.qml
M  +1    -19   src/kclock/qml/timer/TimerFormDialog.qml

https://invent.kde.org/utilities/kclock/-/commit/033e713e86d0f91c1f89c1f69241bd169787c9bc
Comment 4 Gladox114 2025-06-26 21:15:52 UTC
(In reply to Devin Lin from comment #3)
> Git commit 033e713e86d0f91c1f89c1f69241bd169787c9bc by Devin Lin.
> Committed on 26/06/2025 at 02:50.
> Pushed by devinlin into branch 'release/25.04'.
> 
> timers: Fix preset creation and usage (25.04)
> 
> This fix is already in master, this is just for 25.04.x
> 
> Timers from the preset model were created with the values of the form.
> Fix this to actually create timers from the stored presets.
> 
> M  +18   -10   src/kclock/qml/timer/TimerForm.qml
> M  +1    -19   src/kclock/qml/timer/TimerFormDialog.qml
> 
> https://invent.kde.org/utilities/kclock/-/commit/
> 033e713e86d0f91c1f89c1f69241bd169787c9bc

Thanks a lot