| Summary: | Certain sources of Firefox show a 0.0 average rating with 0 reviews, but with correct bar charts and Show All Reviews contents | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | ralf-speer |
| Component: | discover | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | akselmo, aleixpol, john.kizer, kdedev, nate |
| Priority: | NOR | ||
| Version First Reported In: | 6.2.5 | ||
| Target Milestone: | --- | ||
| Platform: | SteamOS | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/eee1a63f870d4cc5ffc891aff566017505ea4c1f | Version Fixed/Implemented In: | 6.5.0 |
| Sentry Crash Report: | |||
| Attachments: | Photo of the Rating for Firefox | ||
|
Description
ralf-speer
2025-06-11 11:23:51 UTC
This is a weird one - I can reproduce with Firefox on my Fedora KDE 42 device, Discover built from git master, but I can't find another application where this issue reproduces - and it does show the correct average on a duplicate listing for Fedora Flatpaks.
For what it's worth, when loading the Firefox page, there's one message printed to the terminal: couldn't find QList("mozilla-seamonkey.desktop", "org.mozilla.firefox") which is supposedly extended by "mozilla-noscript"
Thanks!
(In reply to John Kizer from comment #1) > This is a weird one - I can reproduce with Firefox on my Fedora KDE 42 > device, Discover built from git master, but I can't find another application > where this issue reproduces - and it does show the correct average on a > duplicate listing for Fedora Flatpaks. > > For what it's worth, when loading the Firefox page, there's one message > printed to the terminal: couldn't find QList("mozilla-seamonkey.desktop", > "org.mozilla.firefox") which is supposedly extended by "mozilla-noscript" > > Thanks! Yeah I guessed so. A Friend of mine also looked into it with his Steam Deck (Here it is an OLED Version, I have an LCD Version) and pretty much the same happened. I could write a Support Ticket also for Valve. Is there anything I should test or try out on my Steamdeck? Can I provide some further Information? If so just let me know :) (In reply to ralf-speer from comment #2) > I could write a Support Ticket also for Valve. Is there anything I should > test or try out on my Steamdeck? Can I provide some further Information? > > If so just let me know :) Thanks - I'll have to defer to developers with more knowledge of what might be causing this - something with the upstream server, or something in Discover itself. I'd be pretty surprised if it's SteamOS-specific, though, since I could reproduce the issue on my Fedora KDE 42 device running the current upstream KDE master version of Discover, without any SteamOS-specific components in use. Can reproduce the issue right now on Fedora KDE 42 as well, albeit with everything KDE built from source on top of it. Been looking into this bug. Somehow the rating field gets an empty rating: root.application.rating.packageName is empty. Figured it out. Ratings file has `org.mozilla.Firefox` but we're looking for `org.mozilla.firefox`, so we need to likely make this case insensitive A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/1168 Git commit b780286a46bc0edae82e622330b67a474d0dcd96 by Akseli Lahtinen. Committed on 30/09/2025 at 13:39. Pushed by akselmo into branch 'master'. OdrsReviewsBackend: Set all rating packagenames to lowercase When comparing between ratings, we could end up in situations where we're looking a rating for `org.mozilla.Firefox` but the package name is reported as `org.mozilla.firefox`. Due to QHash comparison being case-sensitive, we should just set all ratings during parsing into lowercase. Then also set the package names lowercase when looking for them in the ratings hash. M +4 -3 libdiscover/appstream/OdrsReviewsBackend.cpp https://invent.kde.org/plasma/discover/-/commit/b780286a46bc0edae82e622330b67a474d0dcd96 Git commit eee1a63f870d4cc5ffc891aff566017505ea4c1f by Akseli Lahtinen. Committed on 30/09/2025 at 14:07. Pushed by akselmo into branch 'Plasma/6.5'. OdrsReviewsBackend: Set all rating packagenames to lowercase When comparing between ratings, we could end up in situations where we're looking a rating for `org.mozilla.Firefox` but the package name is reported as `org.mozilla.firefox`. Due to QHash comparison being case-sensitive, we should just set all ratings during parsing into lowercase. Then also set the package names lowercase when looking for them in the ratings hash. (cherry picked from commit b780286a46bc0edae82e622330b67a474d0dcd96) Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev> M +4 -3 libdiscover/appstream/OdrsReviewsBackend.cpp https://invent.kde.org/plasma/discover/-/commit/eee1a63f870d4cc5ffc891aff566017505ea4c1f |