| Summary: | Klipper rasterises Inkscape clipboard content across restart | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | pbs3141 |
| Component: | Clipboard widget & pop-up | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 4wy78uwh, david.decos, kde, matthias.j.w.heil, nate, qydwhotmail |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | 6.3.4 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=504469 https://bugs.kde.org/show_bug.cgi?id=505209 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/abc5b7fdf82addfb042c49b47b0f7b942511fb42 | Version Fixed/Implemented In: | 6.4.6 |
| Sentry Crash Report: | |||
|
Description
pbs3141
2025-05-18 14:22:09 UTC
I lack the technical knowledge to fully confirm this, but think that I am seeing the same problem in LibreOffice Impress; Ctrl+C -> Ctrl+V on a shape rasterises it; for some reason, however, a second attempt seems to usually work. When copying to the clipboard the client will say "this data is available as png, jpeg, webp, gif, xml, svg" backing up all of them would be wasteful so we have to make a decision and pick text and pngs. I see what I assume to be the same bug in LibreOffice Impress, where it is quite annoying; copied boxes containing text become rasterized, which makes them useless. Usually repeating the Copy & Paste-operation solves the problem. Copying & Pasting worked without problems in the past, so I don't fully understand why this bug is now marked as "RESOLVED INTENTIONAL" - it significantly and negatively affects usability of widely used software. Sounds similar.
I do still think we should only save one mimetype, but it doesn't sound like our choice is very sensible.
>Prior to plasma version 6.3.0, this was the case.
I hadn't read this the first time round, lets revisit then.
If svg is offered by the application, you could only save svg and text, or svg and png, or just svg. At least when copying from Inkscape, any of these would fix the regression. I would recommend never saving png if svg is present, since plasma does not use the png for anything (e.g. showing a preview). Saving the png only wastes storage space, and time spent generating it. Even if plasma did show a preview, it would be better to generate it from the svg on demand, at whatever resolution it requires. As for text, it would be nice not to save that either, but that might break pasting an svg into a text editor, so text might need saving alongside svg. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5887 Git commit d2c4401e8afba1c7478c826265e5efb7f0ae2a85 by Fushan Wen. Committed on 03/10/2025 at 23:36. Pushed by fusionfuture into branch 'master'. klipper: fix copying data from office suites Without checking if the uuid role changes, the async-loaded image data will override the current clipboard because when images are saved to local, the dataChanged signal will also be emitted to notify the frontend to show the image, thus triggering the slot for `HistoryModel::changed`. M +4 -2 klipper/historymodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/d2c4401e8afba1c7478c826265e5efb7f0ae2a85 Git commit 0207ca00737939f69cfc04f99f2b4573d479fac5 by Fushan Wen. Committed on 03/10/2025 at 23:37. Pushed by fusionfuture into branch 'Plasma/6.5'. klipper: fix copying data from office suites Without checking if the uuid role changes, the async-loaded image data will override the current clipboard because when images are saved to local, the dataChanged signal will also be emitted to notify the frontend to show the image, thus triggering the slot for `HistoryModel::changed`. (cherry picked from commit d2c4401e8afba1c7478c826265e5efb7f0ae2a85) Co-authored-by: Fushan Wen <qydwhotmail@gmail.com> M +4 -2 klipper/historymodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/0207ca00737939f69cfc04f99f2b4573d479fac5 Git commit abc5b7fdf82addfb042c49b47b0f7b942511fb42 by Fushan Wen. Committed on 03/10/2025 at 23:38. Pushed by fusionfuture into branch 'Plasma/6.4'. klipper: fix copying data from office suites Without checking if the uuid role changes, the async-loaded image data will override the current clipboard because when images are saved to local, the dataChanged signal will also be emitted to notify the frontend to show the image, thus triggering the slot for `HistoryModel::changed`. (cherry picked from commit d2c4401e8afba1c7478c826265e5efb7f0ae2a85) Co-authored-by: Fushan Wen <qydwhotmail@gmail.com> (cherry picked from commit 0207ca00737939f69cfc04f99f2b4573d479fac5) Co-authored-by: Fushan Wen <qydwhotmail@gmail.com> M +4 -2 klipper/historymodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/abc5b7fdf82addfb042c49b47b0f7b942511fb42 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5904 Can anyone who applied this fix please check if by any chance it also fixes Bug 505209? I know the bug descriptions make them seem unrelated, but since in comment 1 of Bug 505209 Nate Graham points out a possibly related issue that does remind me heavily of this bug, I'm a bit hopeful. Thanks! Yes, I can confirm that it fixes that issue too. Yay! |