| Summary: | Adding blank "System Monitor Sensor" widgets via click (not drag-and-drop) is broken | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nate Graham <nate> |
| Component: | System Monitor widgets | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | ahiemstra, cwo.kde, notmart |
| Priority: | HI | Keywords: | regression |
| Version First Reported In: | 6.3.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libplasma/-/commit/21302cc897723992e964123d073641f7ecc642ae | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2025-05-16 15:40:11 UTC
The pre-made widgets work; it's only the blank one that's broken. Can reproduce. Note that only adding them by clicking in the WidgetExplorer is broken, if I drag&drop them there, it works as usual. Fascinating. I can reproduce that too. (In reply to cwo from comment #2) > Note that only adding them by clicking in the WidgetExplorer is broken, if I > drag&drop them there, it works as usual. Don't try it with a panel, it won't show up at all. A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1311 Git commit 0db46b7c5cc3e429b293daa1d12036ceddb90d79 by Christoph Wolk. Committed on 16/05/2025 at 20:59. Pushed by cwo into branch 'master'. plasma/pluginloader: actually use pluginName when loading plugins loadApplet takes the plugin name either as an applet name or as a full path, but KPluginMetaData only wants the actual name. So we save the plugin name in pluginName, then ignore it and use the original argument anyway. WidgetExplorer, when clicking the applet, sends the path, so all Kpackage + plugin widgets added this way are considered qml-only plugins and their applet code isn't started (unless they have a parent plugin, as the rootpath metadata is the name, or Plasma is restarted and the name is read from appletsrc). Instead we actually use the variable we computed and everything works again. M +1 -1 src/plasma/pluginloader.cpp https://invent.kde.org/plasma/libplasma/-/commit/0db46b7c5cc3e429b293daa1d12036ceddb90d79 Git commit 21302cc897723992e964123d073641f7ecc642ae by Christoph Wolk. Committed on 16/05/2025 at 21:18. Pushed by cwo into branch 'Plasma/6.4'. plasma/pluginloader: actually use pluginName when loading plugins loadApplet takes the plugin name either as an applet name or as a full path, but KPluginMetaData only wants the actual name. So we save the plugin name in pluginName, then ignore it and use the original argument anyway. WidgetExplorer, when clicking the applet, sends the path, so all Kpackage + plugin widgets added this way are considered qml-only plugins and their applet code isn't started (unless they have a parent plugin, as the rootpath metadata is the name, or Plasma is restarted and the name is read from appletsrc). Instead we actually use the variable we computed and everything works again. (cherry picked from commit 0db46b7c5cc3e429b293daa1d12036ceddb90d79) Co-authored-by: Christoph Wolk <cwo.kde@posteo.net> M +1 -1 src/plasma/pluginloader.cpp https://invent.kde.org/plasma/libplasma/-/commit/21302cc897723992e964123d073641f7ecc642ae |