| Summary: | Now Playing shows overlapping metadata and lyrics on the Metadata tab at certain window widths | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Saihaj Johal <personal> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | john.kizer |
| Priority: | NOR | ||
| Version First Reported In: | 25.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/-/commit/e7dedf3b02b0526dcd086972a4369a8efb8746cd | Version Fixed/Implemented In: | 25.04.2 |
| Sentry Crash Report: | |||
| Attachments: | The overlap between lyrics and metadata occuring. | ||
Hi - I can reproduce this as well. Thanks! Git commit 19f9de65f1d6814efb7ce2d31b2f62f03df8ca02 by Christoph Wolk. Committed on 23/05/2025 at 18:44. Pushed by cwo into branch 'master'. qml/ContextView: don't show Lyrics when they're invisible ContextView attempts to hide the lyrics when not selected or in wide mode by setting the containing Item's implicitWidth to zero. But this doesn't work (anymore?); the lyrics are still displayed, centered around the zero-width position where they would appear (so half off-screen) and overlapping the metadata area. To hide text this way, clip must be set to true. Instead, we might as well directly set visible; this seems clearer than an implicitWidth + clip trick and is likely faster as well as no separate checks are necessary about what would fit (which is nothing anyway). FIXED-IN: 25.04.2 M +1 -0 src/qml/ContextView.qml https://invent.kde.org/multimedia/elisa/-/commit/19f9de65f1d6814efb7ce2d31b2f62f03df8ca02 Git commit e7dedf3b02b0526dcd086972a4369a8efb8746cd by Christoph Wolk. Committed on 23/05/2025 at 20:51. Pushed by cwo into branch 'release/25.04'. qml/ContextView: don't show Lyrics when they're invisible ContextView attempts to hide the lyrics when not selected or in wide mode by setting the containing Item's implicitWidth to zero. But this doesn't work (anymore?); the lyrics are still displayed, centered around the zero-width position where they would appear (so half off-screen) and overlapping the metadata area. To hide text this way, clip must be set to true. Instead, we might as well directly set visible; this seems clearer than an implicitWidth + clip trick and is likely faster as well as no separate checks are necessary about what would fit (which is nothing anyway). FIXED-IN: 25.04.2 (cherry picked from commit 19f9de65f1d6814efb7ce2d31b2f62f03df8ca02) Co-authored-by: Christoph Wolk <cwo.kde@posteo.net> M +1 -0 src/qml/ContextView.qml https://invent.kde.org/multimedia/elisa/-/commit/e7dedf3b02b0526dcd086972a4369a8efb8746cd |
Created attachment 181274 [details] The overlap between lyrics and metadata occuring. SUMMARY When playing a file with embedded lyrics, when making the window narrower when using the Now Playing screen, the metadata text and lyrics overlap each other instead of remaining in separate tabs. Synced lyrics are also not clickable in this state. When viewing just the lyrics there is no metadata text, and it works as expected. STEPS TO REPRODUCE 1. Play a file with embedded lyrics. 2. Go to "Now Playing" tab. 3. Make the window as narrow as possible (although happens on slightly larger window sizes too. 4. Select the metadata option (i symbol). OBSERVED RESULT Metadata text and lyrics overlap. EXPECTED RESULT Only the metadata is shown. SOFTWARE/OS VERSIONS Operating System: Fedora Linux 42 KDE Plasma Version: 6.3.5 KDE Frameworks Version: 6.13.0 Qt Version: 6.9.0 See attached screen shot to see this issue occur.