Summary: | Clicking "Save As" on KColorSchemeEditor does not update the list of available color schemes | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | KDE User <cecij72018> |
Component: | kcm_colors | Assignee: | Plasma Bugs List <plasma-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | akselmo, john.kizer, nate, noahadvs, tantalising007, uhhadd |
Priority: | NOR | Keywords: | usability |
Version First Reported In: | 6.3.5 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/2978c36904c41fb4a48c3ff693087f230bb27031 | Version Fixed In: | 6.4.4 |
Sentry Crash Report: | |||
Attachments: | Reloading page required to see color scheme created with Save As |
Description
KDE User
2025-05-10 12:38:53 UTC
Cannot reproduce this on current git master. I can reproduce on my Fedora KDE 42 device and on a Neon VM, with Plasma 6.3.5 and Frameworks 6.14.0. Thanks! Created attachment 181362 [details]
Reloading page required to see color scheme created with Save As
Can also reproduce this Operating System: Fedora Linux 42 KDE Plasma Version: 6.4.80 KDE Frameworks Version: 6.17.0 Qt Version: 6.9.1 Kernel Version: 6.15.8-200.fc42.x86_64 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 3600 6-Core Processor Memory: 16 GiB of RAM (15.5 GiB usable) Graphics Processor: AMD Radeon RX 6600 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5726 Git commit 6993f8e3b1652ae09ebdfbc51a301cf2f7f07ecb by Akseli Lahtinen. Committed on 01/08/2025 at 09:58. Pushed by akselmo into branch 'master'. KCMColors: Do not forward the output of editDialogProcess When we are done editing a colorscheme and save it, dialogProcess outputs in stdout the names of the colorschemes we save. ForwardedChannels would send those names to the stdout of the main process (the KCM), so the dialogProcess stdout was always empty. Instead, just use defaults: Separate channels (stdout/stderr) and then just read it as usual. This then allows the reloading to work. M +0 -1 kcms/colors/colors.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/6993f8e3b1652ae09ebdfbc51a301cf2f7f07ecb Git commit 2978c36904c41fb4a48c3ff693087f230bb27031 by Akseli Lahtinen. Committed on 01/08/2025 at 11:39. Pushed by akselmo into branch 'Plasma/6.4'. KCMColors: Do not forward the output of editDialogProcess When we are done editing a colorscheme and save it, dialogProcess outputs in stdout the names of the colorschemes we save. ForwardedChannels would send those names to the stdout of the main process (the KCM), so the dialogProcess stdout was always empty. Instead, just use defaults: Separate channels (stdout/stderr) and then just read it as usual. This then allows the reloading to work. (cherry picked from commit 6993f8e3b1652ae09ebdfbc51a301cf2f7f07ecb) Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev> M +0 -1 kcms/colors/colors.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/2978c36904c41fb4a48c3ff693087f230bb27031 |