Bug 503862

Summary:	Remove "Disable this popup" when klipper popups an action
Product:	[Plasma] plasmashell	Reporter:	saunders
Component:	Clipboard widget & pop-up	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	nate, qydwhotmail
Priority:	NOR
Version First Reported In:	6.3.5
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/5762c3fa805f589018bb2fb5a980e2bcef167dc4	Version Fixed In:	6.4.0
Sentry Crash Report:

Description saunders 2025-05-06 21:39:55 UTC

SUMMARY
When you copy text that matches an action it popups an option to run a pre-defined command. Everytime this pops up it has a "Disable this popup" that cannot be removed/disabled. When I add an action I do not need the option to disable it every time I use it. From a usability standpoint I would like an option to be added that toggles/disables this option popping up each time.

ps. this was added under "general" as I don't see any Klipper product to file it under.

Comment 1 Nate Graham 2025-05-07 15:01:45 UTC

I think this was added in the past when the popup was active by default, to increase the discoverability of disabling it because many people found it annoying.

Now that it's opt-in, the people who see this are by definition people who don't find it annoying, so this proposal makes sense to me.

Comment 2 Bug Janitor Service 2025-05-07 21:27:42 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5454

Comment 3 Nate Graham 2025-05-12 22:20:49 UTC

Git commit 5762c3fa805f589018bb2fb5a980e2bcef167dc4 by Nate Graham.
Committed on 12/05/2025 at 22:20.
Pushed by ngraham into branch 'master'.

klipper: remove the "disable this popup" menu item

# Reason for the change
My sense is that this was added during the time when there were
clipboard actions included by default, because we wanted to provide a
way to disable this potentially unexpected and intrusive popup.

However we haven't shipped clipboard actions for a long time, at least 8
years. Thus, almost everyone using them has set them up manually. This
means if they did want to disable the popup, they already know how from
the config window.

Let's remove it.


# Test Plan
1. Enable "Show action popup menu \[X\] Immediately on selection" in Klipper's settings window
2. Copy a URL


# Bugs fixed
Related: bug 412264
FIXED-IN: 6.4.0

M  +5    -9    doc/klipper/index.docbook
M  +0    -16   klipper/klipper.cpp
M  +0    -1    klipper/klipper.h
M  +0    -9    klipper/urlgrabber.cpp
M  +0    -1    klipper/urlgrabber.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/5762c3fa805f589018bb2fb5a980e2bcef167dc4