Bug 503478

Summary: Default state of Comics widget on desktop is not ideal
Product: [Plasma] plasmashell Reporter: Nate Graham <nate>
Component: Comic widgetAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: cwo.kde
Priority: NOR Keywords: regression
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 6.4.0
Sentry Crash Report:
Attachments: Default appearance not ideal

Description Nate Graham 2025-04-28 14:49:26 UTC
Created attachment 180733 [details]
Default appearance not ideal

See attached screenshot. Basically, it's too small to fit the content, and two placeholder messages are shown simultaneously.
Comment 1 Nate Graham 2025-04-28 14:52:34 UTC
It looks like the overlapping messages are a regression from https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/768, which I was testing at the time. However the background being too small for the content is an issue on master too.
Comment 2 Bug Janitor Service 2025-04-29 14:31:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/773
Comment 3 cwo 2025-05-05 15:32:04 UTC
Git commit 9c0712c95c1f24bb343799445d19c87d188a7ba0 by Christoph Wolk.
Committed on 05/05/2025 at 15:26.
Pushed by cwo into branch 'master'.

applets/comic: use fallback error placeholder for tiny widgets

Since the original implementation of resizing the widget on showing a
PlaceholderMessage was abandonded, the placeholder could escape the area
of the widget. This looks broken.

Instead, we use a second fallback placeholder that only shows an error
icon if the main one does not fit. Along the way, we get rid of some
fiddling with implicit sizes that is no longer necessary without the
automatic resizing.
FIXED-IN: 6.4.0

M  +13   -15   applets/comic/qml/ComicCentralView.qml

https://invent.kde.org/plasma/kdeplasma-addons/-/commit/9c0712c95c1f24bb343799445d19c87d188a7ba0