Bug 503174

***
If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports

Please remove this comment after reading and before submitting - thanks!
***

SUMMARY
Loving the new KRDC with libfreerdp integrated and working nicely in Wayland.  Found out it does not use domain properly when logging in through a new-style bookmark (?domain=NETBIOSDOMAIN).  Looks like I just needed one line to make sure the domain is passed along.  

--- rdpsession.cpp.orig 2025-04-22 11:16:04.490432543 -0400
+++ rdpsession.cpp      2025-04-22 11:16:38.273906771 -0400
@@ -1103,6 +1103,7 @@
 
     if (m_firstPasswordTry && m_user.size()) {
         *username = _strdup(m_user.toUtf8().data());
+        if (m_domain.size()) *domain = _strdup(m_domain.toUtf8().data());
         if (m_password.size()) {
             *password = _strdup(m_password.toUtf8().data());
             m_firstPasswordTry = false;
@@ -1228,4 +1229,4 @@
 void RdpSession::setRemoteCursor(const QCursor &cursor)
 {
     Q_EMIT cursorChanged(cursor);
-}
\ No newline at end of file
+}


STEPS TO REPRODUCE
1. create a new RDP connection to a Windows server that uses domain logins; either converting an existing DOMAIN\username from wallet, or a new one
2. this should save the bookmark with the new-style ?domain=DOMAIN querystring and you can try to connect with it
3. your connection will fail because it will omit the domain (if you have a local account with the same username and password it will work but it will login as the local account not the domain one)

OBSERVED RESULT
it doesn't login or uses the local account instead of domain

EXPECTED RESULT
login as the domain account

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: 
KDE Plasma Version: 
KDE Frameworks Version: 6.12.0
Qt Version: 6.8.3

ADDITIONAL INFORMATION