| Summary: | Typo "telepony" in telephony plugin | ||
|---|---|---|---|
| Product: | [Applications] kdeconnect | Reporter: | Nick Leverton <nick> |
| Component: | plasmoid | Assignee: | Albert Vaca Cintora <albertvaka> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 24.01.75 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/kdeconnect-kde/-/commit/d3ae9a56b9231fffcdcd37fa27fa8c05a85c797b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Fix DBUS path typo telepony/telephony | ||
This change has been released already, I'm not sure it's worth it making another breaking change :/ Can you submit the change via Gitlab [1], so we can discuss there? [1] https://invent.kde.org/network/kdeconnect-kde/ Of course, copied as https://invent.kde.org/network/kdeconnect-kde/-/issues/33 As I understand things, this issue shouldn't directly affect me anyway when I upgrade as I only use the Plasma UI, not any outside Dbus controls, so I'm probably OK if it WONTFIX for whatever reason. Thankyou for looking anyway. A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/832 Git commit d3ae9a56b9231fffcdcd37fa27fa8c05a85c797b by Simon Redman, on behalf of Natsumi Higa. Committed on 16/06/2025 at 02:27. Pushed by sredman into branch 'master'. Fix D-Bus path typo This MR aims to incorporate a patch created by Nick Leverton. Fixes #33. M +1 -1 plugins/telephony/telephonyplugin.cpp https://invent.kde.org/network/kdeconnect-kde/-/commit/d3ae9a56b9231fffcdcd37fa27fa8c05a85c797b |
Created attachment 180150 [details] Fix DBUS path typo telepony/telephony Commit 69d6c172 seems to have introduced a typo in the filename path used to control telephony devices. A DBUS path which previously expanded to "/modules/kdeconnect/devices/DEVICE/telephony" now becomes "/modules/kdeconnect/devices/DEVICE/telepony", note difference in final path element. On the assumption that this break in 24.xx onwards with 23.xx behaviour is unintentional, the attached patch ought to fix it. I'm still on 23.xx myself as I use Debian Stable but I was looking into forthcoming updates in the next Debian release and happened to notice this. Hope this patch is appropriate and useful.