Summary: | Unlocking a vault always opens a Dolphin window instead of a tab | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Damglador <vse.stopchanskyi> |
Component: | Vaults widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | ivan.cukic, nate |
Priority: | NOR | ||
Version First Reported In: | 6.3.3 | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-vault/-/commit/189cc0e09d2273e2558cb6111d88cc42491870d8 | Version Fixed In: | 6.4.0 |
Sentry Crash Report: |
Description
Damglador
2025-03-31 13:04:10 UTC
Can confirm. Not sure if this is Plasma Vault's fault, or Dolphin's. Needs investigation. Opening a folder on desktop also have similar behavior. It opens a new Dolphin window instead of a tab, but if there is a tab for the folder already in a Dolphin window, it just points to that tab. I don't think I can reproduce that with the vault widget, because it opens the folder only after I unlock it and unlocking it second time will just give an error. I don't know if these two bugs related. If I open the folder where vault I choose vault to be before I unlock it, it still opens a new window It looks like this is actually intentional; see https://invent.kde.org/plasma/plasma-vault/-/blob/master/kded/service.cpp?ref_type=heads#L361 and Bug 445542. We could perhaps narrow the condition here so that it only forces a new window if there are multiple activities and the vault being opened is activity-specific. Git commit 189cc0e09d2273e2558cb6111d88cc42491870d8 by Nate Graham. Committed on 11/04/2025 at 22:51. Pushed by ngraham into branch 'only-open-new-dolphin-instance-if-needed'. kded: only open vault in new Dolphin window if needed The code deliberately forces a new Dolphin window to prevent issues when the opened vault is activity-specific and there's already a Dolphin window open in a different activity. However none of this is necessary if there's only one actvity or the vault being opened is not activity-specific. Handle those cases too so we can use the normal behavior of opening a new tab more often. FIXED-IN: 6.4.0 M +6 -2 kded/service.cpp https://invent.kde.org/plasma/plasma-vault/-/commit/189cc0e09d2273e2558cb6111d88cc42491870d8 Thanks, Nate That merge request was merged, so this will be fixed in Plasma 6.4.0. |