Bug 502024

Summary: KOrganizer should not allow to add an ical file calendar without path
Product: [Applications] korganizer Reporter: premiumshelf56
Component: generalAssignee: kdepim bugs <pim-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: krammer, winter
Priority: NOR    
Version First Reported In: 6.3.3   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 6.4.1
Sentry Crash Report:

Description premiumshelf56 2025-03-26 14:26:50 UTC 
SUMMARY
KOrganizer should not allow to add an ical file calendar without path

STEPS TO REPRODUCE
Add an "iCal Calendar File" without giving it a filename or URL

OBSERVED RESULT
KOrganizer doesn't complain and even allows adding events to the calendar

EXPECTED RESULT
An error

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.3.3
KDE Frameworks Version: 6.12.0
Qt Version: 6.8.2
Kernel Version: 6.13.7-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 3600 6-Core Processor
Memory: 33.6 GB of RAM
Graphics Processor: NVIDIA GeForce RTX 3060

ADDITIONAL INFORMATION
Comment 1 Kevin Krammer 2025-03-26 15:34:07 UTC 
I can confirm that the "OK" button of the dialog is already enabled when it comes up.
See also https://discuss.kde.org/t/korganizer-calendar-data-location/32036

KOrganizer: 6.3.3 (24.12.3)
KDE Frameworks: 6.12.0
Qt: Using 6.8.2 and built against 6.8.2
KDE neon 6.3 (Xcb)

My KDE PIM foo is super rusty but this might be a missing

d->okButton->setEnabled(false);

in the body of https://invent.kde.org/pim/akonadi/-/blob/master/src/widgets/agentconfigurationdialog.cpp?ref_type=heads#L71