| Summary: | New URL/Location Bar background does not indicate edit state (too light/dark) | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Blazer Silving <breakingspell> |
| Component: | URL navigator | Assignee: | KIO Bugs <kio-bugs-null> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | normal | CC: | 4wy78uwh, kdebugs, kdedev, kdelibs-bugs-null, kurobac, mabo, meven, niiinjoe, prettyvanilla |
| Priority: | NOR | ||
| Version First Reported In: | 6.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Blazer Silving
2025-03-16 21:28:06 UTC
> The Location Bar should be visibly different when editing the text field and when not.
Excluding the background color, it is the same for all other visual clues as before
In editing mode, there are many hints that we are in editing path mode:
The icon at the beginning of the path (instead of >), the cursor, the '/' visible, the <X to remove, the V confirmation...
It is more subtle now. I suspect this is mostly a transition phase for something you were visually accustomed to.
Still we might adjust this somewhat, not clear how.
We don't want to use the toolbar background color, maybe a 1.5 lighter version of it.
> In editing mode, there are many hints that we are in editing path mode: The icon at the beginning of the path (instead of >), the cursor, the '/' visible, the <X to remove, the V confirmation... Yes, I briefly note that in my initial feedback: Now that the backgrounds share the same color, the ONLY way to tell if you are in edit mode is to be cognizant of the other cues (for me the most visible is the check icon at far end of the bar, requiring scanning the bar to find the icon. > I suspect this is mostly a transition phase for something you were visually accustomed to. A color to indicate the normal state is now missing when it was functional before. This is a regression. The most clear solution would be to use an adjacent shade of the toolbar header for the default bar state: not the exact shade, and not even a 1.5 mix with the edit background (too strong). It will take me some time to draw this up. It's also worth noting the "sunken" state of the bar in all cases now. The bar was formerly in the same plane as the header while in normal mode, and would "sink" into edit mode (looked great). Simply raising the Location Bar (either at rest or on hover) in this same axis would communicate the ability to interact without requiring color work. The bug report that kicked off this entire effort was only requesting this change in the first place. Update, this MR addresses the background shade along with other fixes: https://invent.kde.org/frameworks/kio/-/merge_requests/1842#note_1172777 This also adds an internal toggle for the feature entirely, `m_backgroundEnabled`. While I don't think it's intended, this can be used to fully revert to the old presentation. This is great, but I feel the default contrast should be be stronger, and I still prefer the background to fully match the header/toolbar. I have a few screenshots of what I think would be the best mix for those that prefer a background: https://invent.kde.org/frameworks/kio/-/merge_requests/1842#note_1172684 The best place to discuss feedback on merge requests is in the MR themselves. I'm going to close this report out since it isn't really reporting a bug, but discussing feedback on those MRs. Thanks for your understanding. |