Bug 501573

Summary:	"ignore face" doesn't work anymore
Product:	[Applications] digikam	Reporter:	FloMUC <jurist-muc>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	metzpinguin
Priority:	NOR
Version First Reported In:	8.6.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/digikam/-/commit/e5f7c327a8877f57ab9a1a70b13a47f9c57fbba6	Version Fixed/Implemented In:	8.7.0
Sentry Crash Report:
Attachments:	Logfile logfile

Description FloMUC 2025-03-16 13:28:38 UTC

SUMMARY
"Ignored" Faces are not saved. 

STEPS TO REPRODUCE
1. install new version
2. database cleanup 
3. rebuild all training data
4. face recognition
5. mark unknown faces / false positives as "ignored"


OBSERVED RESULT
says "ignored", but after leaving the preview, the face bekomes unknown / false positive again.

EXPECTED RESULT
"ignored" faces are saved.

SOFTWARE/OS VERSIONS
Windows 11, digikam 8.6.0
Build Date: 14.03.2025 17:44
Build Architecture: x86_64


ADDITIONAL INFORMATION

Comment 1 Maik Qualmann 2025-03-16 16:08:40 UTC

I can't reproduce it; ignoring it in the preview works here. Ignored faces remain ignored even after rereading the metadata.

Please create a DebugView log from startup until a face is ignored, as described here for Windows:

https://www.digikam.org/contribute/#windows-host

Maik

Comment 2 FloMUC 2025-03-16 19:31:10 UTC

Created attachment 179477 [details]
Logfile

Start debugview
Start Digikam
Clean Faces Database & Rebuild Training Data
Face recogition
** some coincidential USB-Problems here. Nothing to do with digikam **
Add some face tags --> working
ignore faces --> not working
(no actions logged at this instant)
** stopped logging **

Comment 3 Maik Qualmann 2025-03-17 07:14:23 UTC

Unfortunately, the log contains more messages from other programs than from digiKam. Have you enabled internal debugging in the digiKam settings under Miscellaneous -> System and restarted digiKam?

Maik

Comment 4 FloMUC 2025-03-17 18:19:38 UTC

Created attachment 179506 [details]
logfile

Next try: Logging in digikam is activated

1. Starting Digikam (up to line 399)
2. Ignoring 5 faces in different pictures (up to line 500) --> not working (face returns after return to preview, number of recomendations is unchanged)
3. Accepting 3 faces, write to file --> working 

End Logging

Thanks for your help ;-)

Comment 5 Maik Qualmann 2025-03-18 17:58:29 UTC

Git commit e8cd2971b1105d42d042cd3dbc0d1c9d1c6039b8 by Maik Qualmann.
Committed on 18/03/2025 at 17:57.
Pushed by mqualmann into branch 'master'.

test to identify the problem in the face confirmation
Related: bug 501684

M  +2    -1    core/utilities/facemanagement/items/facegroup.cpp

https://invent.kde.org/graphics/digikam/-/commit/e8cd2971b1105d42d042cd3dbc0d1c9d1c6039b8

Comment 6 Maik Qualmann 2025-03-18 21:02:40 UTC

Git commit e5f7c327a8877f57ab9a1a70b13a47f9c57fbba6 by Maik Qualmann.
Committed on 18/03/2025 at 21:01.
Pushed by mqualmann into branch 'master'.

fix race condition for ignore face
FIXED-IN: 8.7.0

M  +1    -1    NEWS
M  +4    -23   core/utilities/facemanagement/items/facegroup.cpp
M  +17   -6    core/utilities/facemanagement/pipelines/edit/facepipelineedit.cpp
M  +1    -1    core/utilities/facemanagement/pipelines/edit/facepipelineedit.h

https://invent.kde.org/graphics/digikam/-/commit/e5f7c327a8877f57ab9a1a70b13a47f9c57fbba6