| Summary: | The icon for "Open Terminal Here" is always Konsole regardless of user's actual default terminal emulator | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | SC <kde> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | angxddeep, dolphin-bugs-null, meven, nate |
| Priority: | NOR | ||
| Version First Reported In: | 24.12.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/62b12e9c307372100a7e70176abd45f6628d1b2b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Doesn't work on Fedora KDE | ||
|
Description
SC
2025-03-13 07:48:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/935 Git commit eaaeb1b7629cc3c59933101d24dd0c2c67ef1276 by Méven Car, on behalf of Angus McLean. Committed on 17/03/2025 at 08:14. Pushed by meven into branch 'master'. contextmenu: Use default terminal's icons for "Open Terminal" and "Open Terminal Here" actions The "Open Terminal" and "Open Terminal Here" actions now use the icon of the user default terminal emulator application, instead of always using the "utilities-terminal" icon. M +9 -2 src/dolphinmainwindow.cpp https://invent.kde.org/system/dolphin/-/commit/eaaeb1b7629cc3c59933101d24dd0c2c67ef1276 Created attachment 182490 [details]
Doesn't work on Fedora KDE
Even after the PR has been merged 3 months before still it doesn't work on my system and the the second entry to open terminal in picture in the attachment is label added by ghossty it's a separate issue that I have reported previously #501134 Operating System: Fedora Linux 42 KDE Plasma Version: 6.4.0 KDE Frameworks Version: 6.15.0 Qt Version: 6.9.1 Kernel Version: 6.14.11-300.fc42.x86_64 (64-bit) Graphics Platform: Wayland Processors: 8 × Intel® Core™ i5-10210U CPU @ 1.60GHz Memory: 8 GiB of RAM (7.6 GiB usable) Graphics Processor 1: NVIDIA GeForce MX350 Graphics Processor 2: Intel® UHD Graphics Manufacturer: TIMI Product Name: Mi NoteBook Horizon Edition 14 I've proposed reverting that change and fixing it in a different way in https://invent.kde.org/system/dolphin/-/merge_requests/1003. (In reply to Angad from comment #4) > Even after the PR has been merged 3 months before still it doesn't work on > my system and the the second entry to open terminal in picture in the > attachment is label added by ghossty it's a separate issue that I have > reported previously #501134 > > Operating System: Fedora Linux 42 This hasn't been cherry-picked, so you probably didn't test the patch. It is only in 25.08, currently. Git commit 62b12e9c307372100a7e70176abd45f6628d1b2b by Méven Car, on behalf of Bharadwaj Raju. Committed on 07/08/2026 at 10:17. Pushed by meven into branch 'master'. Fix icon lookup for "Open Terminal" actions Using KDesktopFile to read the desktop entry from a desktop name (i.e. "org.something.terminalapp.desktop") is incorrect; KDesktopFile is for making modifications to a desktop entry, and hence does not even try to find existing desktop entries in the correct places. See src/core/kdesktopfile.cpp in the KConfig source code, particularly the call to KConfigPrivate::changeFileName. The result of this is that ultimately it does not find desktop entries located in /usr/share/applications or the Flatpak equivalent, and hence fails to locate icons. Instead, use KService::serviceByStorageId. Steps to reproduce: 1. Install a terminal app like WezTerm 2. Set it as default in System Settings > Default Applications 3. Right click inside a folder in Dolphin 4. Observe the lack of an icon Related: bug 436178 M +3 -3 src/dolphinmainwindow.cpp https://invent.kde.org/system/dolphin/-/commit/62b12e9c307372100a7e70176abd45f6628d1b2b |